Issue 70063005: [Refactoring] Remove include "core/inspector/InspectorInstrumentation.h" from SelectorChecker.h

Issue 70063005: [Refactoring] Remove include "core/inspector/InspectorInstrumentation.h" from SelectorChecker.h (Closed)

Created:
7 years, 1 month ago by tasak

Modified:
7 years, 1 month ago

Reviewers:
Hajime Morrita

CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, caseq+blink_chromium.org, Steve Block, alancutter (OOO until 2018), pfeldman+blink_chromium.org, yurys+blink_chromium.org, dstockwell, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, bemjb+rendering_chromium.org, Timothy Loh, rjwright, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, chromiumbugtracker_adobe.com, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[Refactoring] Remove include "core/inspector/InspectorInstrumentation.h" from SelectorChecker.h To make it possible to add include "StyleResolver.h" to StyleEngine.h, We need to remove the above include from SelectorChecker.h. BUG=305885 TEST=No layout tests, just refactoring. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162180

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
M	Source/core/animation/css/CSSAnimations.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/ElementRuleCollector.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/FontFaceSet.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/SelectorChecker.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.cpp	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download
M	Source/core/dom/StyleEngine.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/StyleSheetScopingNodeList.h	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/StyleSheetScopingNodeList.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderRegion.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hajime Morrita

lgtm. https://codereview.chromium.org/70063005/diff/1/Source/core/dom/SelectorQuery.cpp File Source/core/dom/SelectorQuery.cpp (right): https://codereview.chromium.org/70063005/diff/1/Source/core/dom/SelectorQuery.cpp#newcode183 Source/core/dom/SelectorQuery.cpp:183: // Need to move TreeScope.h to remove duplicate ...

7 years, 1 month ago (2013-11-18 05:02:51 UTC) #2

tasak

Thank you for reviewing. https://codereview.chromium.org/70063005/diff/1/Source/core/dom/SelectorQuery.cpp File Source/core/dom/SelectorQuery.cpp (right): https://codereview.chromium.org/70063005/diff/1/Source/core/dom/SelectorQuery.cpp#newcode183 Source/core/dom/SelectorQuery.cpp:183: // Need to move TreeScope.h ...

7 years, 1 month ago (2013-11-18 05:45:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/70063005/60001

7 years, 1 month ago (2013-11-18 05:46:12 UTC) #4

Message was sent while issue was closed.

Change committed as 162180

Expand Messages | Collapse Messages