Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 75453003: optimize pathops coverage (Closed)

Created:
7 years, 1 month ago by caryclark
Modified:
7 years ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

optimize pathops coverage Remove unused code from SkOpSegment.cpp and friends. Add new tests exposed by coverage. Fix a bug exposed by coverage -- removing the need to detect points that are nearby when intersecting. Add gyp rule for building coverage flavor on Mac. Committed: http://code.google.com/p/skia/source/detail?r=12344

Patch Set 1 #

Patch Set 2 : one more quad test #

Patch Set 3 : remove test start #

Patch Set 4 : fix nearly horizontal curves #

Patch Set 5 : remove unused code now that testing is complete #

Total comments: 2

Patch Set 6 : remove fill parameter from reduce order #

Patch Set 7 : remove fill parameter from reduce order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -236 lines) Patch
src/pathops/SkDCubicIntersection.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
src/pathops/SkDCubicToQuads.cpp View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
src/pathops/SkOpSegment.h View 1 2 3 4 5 4 chunks +13 lines, -9 lines 0 comments Download
src/pathops/SkReduceOrder.h View 1 2 3 4 5 1 chunk +2 lines, -6 lines 0 comments Download
src/pathops/SkReduceOrder.cpp View 1 2 3 4 5 13 chunks +16 lines, -183 lines 0 comments Download
tests/PathOpsCubicIntersectionTest.cpp View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
tests/PathOpsCubicLineIntersectionTest.cpp View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
tests/PathOpsCubicQuadIntersectionTest.cpp View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
tests/PathOpsCubicReduceOrderTest.cpp View 1 2 3 4 5 9 chunks +17 lines, -16 lines 0 comments Download
tests/PathOpsQuadIntersectionTest.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
tests/PathOpsQuadLineIntersectionTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
tests/PathOpsQuadLineIntersectionThreadedTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
tests/PathOpsQuadReduceOrderTest.cpp View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
caryclark
MIke, you're welcome to review all of this CL, but I'm mostly interested in a ...
7 years ago (2013-11-21 14:27:12 UTC) #1
mtklein
lgtm https://codereview.chromium.org/75453003/diff/90001/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/75453003/diff/90001/gyp/common_conditions.gypi#newcode344 gyp/common_conditions.gypi:344: 'GCC_INSTRUMENT_PROGRAM_FLOW_ARCS' : 'YES', Extra space here before : ...
7 years ago (2013-11-21 16:33:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/75453003/90001
7 years ago (2013-11-21 16:53:07 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-21 17:04:36 UTC) #4
Message was sent while issue was closed.
Change committed as 12344

Powered by Google App Engine
This is Rietveld 408576698