optimize pathops coverage

gyp/common_conditions.gypi

 # conditions used in both common.gypi and skia.gyp in chromium
 #
 {
   'defines': [
     'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
     'SK_SUPPORT_GPU=<(skia_gpu)',
     'SK_SUPPORT_OPENCL=<(skia_opencl)',
     'SK_DISTANCEFIELD_FONTSC=<(skia_distancefield_fonts)',
   ],
   'conditions' : [
@@ skipping 319 matching lines @@
 # This old compiler is really bad at figuring out when things are uninitialized, so ignore it.
           [ '<(mac_sdk)==10.6', {
             'xcode_settings': {
               'OTHER_CPLUSPLUSFLAGS': [
                 '-Wno-uninitialized',
               ],
             },
           }],
         ],
         'configurations': {
+          'Coverage': {
+            'xcode_settings': {
+               'GCC_OPTIMIZATION_LEVEL': '0',
+               'GCC_GENERATE_TEST_COVERAGE_FILES': 'YES',
+               'GCC_INSTRUMENT_PROGRAM_FLOW_ARCS' : 'YES',

[mtklein, 2013/11/21 16:33:25]

Extra space here before :

+            },
+          },

[mtklein, 2013/11/21 16:33:25]

When I patch this on 10.9, I get an out/Coverage to build, but no coverage flags
are passed to the compiler and linker.  Neither gcda nor gcno are generated.

I've tried the direct approach,
  'OTHER_CFLAGS':         ['--coverage'],
  'OTHER_CPLUSPLUSFLAGS': ['--coverage'],
  'target_conditions': [
    ['_type == "executable"', {
      'OTHER_LDFLAGS': [ '--coverage' ],
    }],
  ],
but I'm struggling to get the linker --coverage flag to do the right thing,
though it's working great for me on a little 2-file toy example.  Not sure
what's wrong.  If this works for you let's submit it and I can fiddle around
later.

           'Debug': {
             'xcode_settings': {
               'GCC_OPTIMIZATION_LEVEL': '0',
             },
           },
           'Release': {
             'xcode_settings': {
               'GCC_OPTIMIZATION_LEVEL': '<(skia_release_optimization_level)',
             },
             'defines': [ 'NDEBUG' ],
@@ skipping 133 matching lines @@
   'xcode_settings': {
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: