Start splitting RenderParagraph logic out of RenderBlock

Start splitting RenderParagraph logic out of RenderBlock.

In particular, move RenderParagraph-specific code from
hitTestContents, paintContents, simplifiedNormalFlowLayout & addOverflowFromChildren.

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/609cd26b12158755b06a357d8c1ff348d60f92ce

[rafaelw, 2014-11-22 00:25:27]

rafaelw@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2014-11-22 00:35:34]

lgtm

Please improve the change description so someone without context looking this
can understand why we're making this change. It looks liked you tried to do
that? The title of this issue would be good inside the change description.

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderParagraph.cpp (right):

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderParagraph.cpp:72: // We have to hit-test our
line boxes.
Can delete this comment now.

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderParagraph.h (right):

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderParagraph.h:25: virtual void
addOverflowFromChildren() override;
These should all be final which, I believe means you can leave out the override
as well since final implies override.

Also, leave out the "virtual". That's implied by override/final.

[rafaelw, 2014-11-26 19:13:00]

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderParagraph.cpp (right):

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderParagraph.cpp:72: // We have to hit-test our
line boxes.
On 2014/11/22 00:35:34, ojan wrote:
> Can delete this comment now.

Done.

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderParagraph.h (right):

https://codereview.chromium.org/754493002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderParagraph.h:25: virtual void
addOverflowFromChildren() override;
On 2014/11/22 00:35:34, ojan wrote:
> These should all be final which, I believe means you can leave out the
override
> as well since final implies override.
> 
> Also, leave out the "virtual". That's implied by override/final.

Done.

[rafaelw, 2014-11-26 19:15:14]

Committed patchset #3 (id:40001) manually as
609cd26b12158755b06a357d8c1ff348d60f92ce (presubmit successful).