sky/engine/core/rendering/RenderBlockFlow.h - Issue 754493002: Start splitting RenderParagraph logic out of RenderBlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlockFlow.h

Issue 754493002: Start splitting RenderParagraph logic out of RenderBlock (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: preland Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlockFlow.h

diff --git a/sky/engine/core/rendering/RenderBlockFlow.h b/sky/engine/core/rendering/RenderBlockFlow.h

index 34806d1d6571cfaba2bc1d3911f43d114dd58203..008a2b5c252f6907c9a4358d6734200bdced9d80 100644

--- a/sky/engine/core/rendering/RenderBlockFlow.h

+++ b/sky/engine/core/rendering/RenderBlockFlow.h

@@ -115,8 +115,6 @@ public:

return obj->isOutOfFlowPositioned() && !obj->style()->isOriginalDisplayInlineType() && !obj->container()->isRenderInline();

}

- void addOverflowFromInlineChildren();

// FIXME: This should be const to avoid a const_cast, but can modify child dirty bits

void computeInlinePreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth);