Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 754393002: Allow the PDF extension to load its plugin correctly (Closed)

Created:
6 years ago by raymes
Modified:
6 years ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow the PDF extension to load its plugin correctly This changes the PDF extensions CSP so it can correctly load its plugin. Previously we were loading it as an <object> and specifying a src attribute which isn't a valid way to load a plugin and causes some things not to function correctly. Now we instead load it as an <embed> which can have a src attribute. BUG=416328 Committed: https://crrev.com/5075bd244002f56c4bfee1bf869c034118c08c65 Cr-Commit-Position: refs/heads/master@{#305783}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/pdf/manifest.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/pdf/basic_test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
raymes
6 years ago (2014-11-25 13:48:17 UTC) #2
Sam McNally
lgtm
6 years ago (2014-11-25 22:25:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754393002/20001
6 years ago (2014-11-26 01:07:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/9218) mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/9237)
6 years ago (2014-11-26 02:08:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754393002/40001
6 years ago (2014-11-26 03:12:38 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-11-26 04:44:01 UTC) #10
commit-bot: I haz the power
6 years ago (2014-11-26 04:44:44 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5075bd244002f56c4bfee1bf869c034118c08c65
Cr-Commit-Position: refs/heads/master@{#305783}

Powered by Google App Engine
This is Rietveld 408576698