chrome/browser/resources/pdf/pdf.js - Issue 754393002: Allow the PDF extension to load its plugin correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 754393002: Allow the PDF extension to load its plugin correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index 4a270f5a2fba4c96c043ad2a1f071e7730eae4be..18317eb2fc8f2ba07326967b62460a171b5f50cf 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -60,7 +60,7 @@ function PDFViewer(streamDetails) {

// element is sized to fill the entire window and is set to be fixed

// positioning, acting as a viewport. The plugin renders into this viewport

// according to the scroll position of the window.

- this.plugin_ = document.createElement('object');

+ this.plugin_ = document.createElement('embed');

// NOTE: The plugin's 'id' field must be set to 'plugin' since

// chrome/renderer/printing/print_web_view_helper.cc actually references it.

this.plugin_.id = 'plugin';

« no previous file with comments | « chrome/browser/resources/pdf/manifest.json ('k') | chrome/test/data/pdf/basic_test.js » ('j') | no next file with comments »