gn format //chrome

gn format //chrome

No intended functionality change.

R=brettw@chromium.org
BUG=348474
Committed: https://crrev.com/a266f951d8d5d571a6929cc9abdf63e2b9bceb8f
Cr-Commit-Position: refs/heads/master@{#306670}

[scottmg, 2014-12-03 18:15:06]

(not too many more)

[tfarina, 2014-12-03 18:30:06]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-12-03 18:30:07]

https://codereview.chromium.org/754223003/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/754223003/diff/1/chrome/BUILD.gn#newcode477
chrome/BUILD.gn:477: [
"$root_gen_dir/ash/resources/ash_resources_${percent}_percent.pak" ]
ouch, is that the format we want? I have a slightly preference for:

sources += [
  ...
]

here in this case.

[tfarina, 2014-12-03 18:36:15]

https://codereview.chromium.org/754223003/diff/1/chrome/app/BUILD.gn
File chrome/app/BUILD.gn (right):

https://codereview.chromium.org/754223003/diff/1/chrome/app/BUILD.gn#newcode142
chrome/app/BUILD.gn:142: "$root_gen_dir/chrome/grit/generated_resources.h",
this seems contradictory. Why would we format inputs as multi-line but not
outputs?

[scottmg, 2014-12-03 19:10:08]

https://codereview.chromium.org/754223003/diff/1/chrome/app/BUILD.gn
File chrome/app/BUILD.gn (right):

https://codereview.chromium.org/754223003/diff/1/chrome/app/BUILD.gn#newcode142
chrome/app/BUILD.gn:142: "$root_gen_dir/chrome/grit/generated_resources.h",
On 2014/12/03 18:36:15, tfarina wrote:
> this seems contradictory. Why would we format inputs as multi-line but not
> outputs?

That seems reasonable to me: https://codereview.chromium.org/780543003

[scottmg, 2014-12-03 20:07:38]

Updated for multiline 'outputs'.

https://codereview.chromium.org/754223003/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/754223003/diff/1/chrome/BUILD.gn#newcode477
chrome/BUILD.gn:477: [
"$root_gen_dir/ash/resources/ash_resources_${percent}_percent.pak" ]
On 2014/12/03 18:30:07, tfarina wrote:
> ouch, is that the format we want? I have a slightly preference for:
> 
> sources += [
>   ...
> ]
> 
> here in this case.

It's preferred at the moment because it's fewer lines (and, fwiw, clang-format
chooses the same formatting).

I'd like to continue with it as-is to get the tree to a baseline, and then we
can work to improve specific instances. It's a bit easier to see the impact of
formatting changes when the rest of the file is formatted so you can see the
impact each individual formatting change across the whole repo.

[brettw, 2014-12-03 20:29:30]

lgtm

[scottmg, 2014-12-03 20:30:34]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-12-03 20:31:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754223003/20001

[commit-bot: I haz the power, 2014-12-03 20:47:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-03 20:49:55]

Patchset 2 (id:??) landed as
https://crrev.com/a266f951d8d5d571a6929cc9abdf63e2b9bceb8f
Cr-Commit-Position: refs/heads/master@{#306670}