Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 780543003: gn format: Add 'outputs' to preferred-multiline lists (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format: Add 'outputs' to preferred-multiline lists For symmetry with 'inputs'. R=brettw@chromium.org,tfarina@chromium.org BUG=348474 Committed: https://crrev.com/fb0c4fd675c191bcc214088881d66170a2e828c0 Cr-Commit-Position: refs/heads/master@{#306668}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/gn/command_format.cc View 1 1 chunk +1 line, -0 lines 1 comment Download
M tools/gn/format_test_data/042.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/format_test_data/042.golden View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
scottmg
6 years ago (2014-12-03 19:11:10 UTC) #1
brettw
lgtm
6 years ago (2014-12-03 19:21:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780543003/20001
6 years ago (2014-12-03 20:42:29 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 20:44:06 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fb0c4fd675c191bcc214088881d66170a2e828c0 Cr-Commit-Position: refs/heads/master@{#306668}
6 years ago (2014-12-03 20:44:45 UTC) #6
tfarina
thanks for considering it and changing to match "inputs". lgtm https://codereview.chromium.org/780543003/diff/20001/tools/gn/command_format.cc File tools/gn/command_format.cc (right): https://codereview.chromium.org/780543003/diff/20001/tools/gn/command_format.cc#newcode292 ...
6 years ago (2014-12-03 21:19:12 UTC) #7
scottmg
6 years ago (2014-12-03 22:16:37 UTC) #8
Message was sent while issue was closed.
On 2014/12/03 21:19:12, tfarina wrote:
> thanks for considering it and changing to match "inputs".
> 
> lgtm
> 
>
https://codereview.chromium.org/780543003/diff/20001/tools/gn/command_format.cc
> File tools/gn/command_format.cc (right):
> 
>
https://codereview.chromium.org/780543003/diff/20001/tools/gn/command_format....
> tools/gn/command_format.cc:292: ident->value().value() == "deps" ||
> ident->value().value() == "inputs" ||
> would you mind moving the "inputs" part into its own line? I think that will
> read better.

Yes, I agree. I wouldn't format it like that either, but clang-format did (sort
of unlucky because "deps" happens to be shorter) so I prefer to just live with
what it does. However, using a local temporary is probably better here anyway:
https://codereview.chromium.org/778833002

Powered by Google App Engine
This is Rietveld 408576698