Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 754023004: Don't handle DCHECK failure in geofencing code. (Closed)

Created:
6 years ago by Marijn Kruisselbrink
Modified:
6 years ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't handle DCHECK failure in geofencing code. BUG=383125 Committed: https://crrev.com/5f97f68bc038393ce05cdb9bd7aa145c01b69027 Cr-Commit-Position: refs/heads/master@{#307273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/child/geofencing/geofencing_dispatcher.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marijn Kruisselbrink
6 years ago (2014-12-08 00:40:51 UTC) #2
scheib
lgtm, perhaps cite the style page link in the change desc.
6 years ago (2014-12-08 16:20:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754023004/1
6 years ago (2014-12-08 16:52:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 17:46:00 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 17:47:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f97f68bc038393ce05cdb9bd7aa145c01b69027
Cr-Commit-Position: refs/heads/master@{#307273}

Powered by Google App Engine
This is Rietveld 408576698