Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/child/geofencing/geofencing_dispatcher.cc

Issue 754023004: Don't handle DCHECK failure in geofencing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/geofencing/geofencing_dispatcher.cc
diff --git a/content/child/geofencing/geofencing_dispatcher.cc b/content/child/geofencing/geofencing_dispatcher.cc
index eec721faf979eaa18d6a140a076231195bb7f35d..57b4f036f61893f314a41c21e9c4fb1c2be05f6f 100644
--- a/content/child/geofencing/geofencing_dispatcher.cc
+++ b/content/child/geofencing/geofencing_dispatcher.cc
@@ -149,8 +149,6 @@ void GeofencingDispatcher::OnRegisterRegionComplete(int thread_id,
blink::WebGeofencingCallbacks* callbacks =
region_registration_requests_.Lookup(request_id);
DCHECK(callbacks);
- if (!callbacks)
- return;
if (status == GEOFENCING_STATUS_OK) {
callbacks->onSuccess();
@@ -168,8 +166,6 @@ void GeofencingDispatcher::OnUnregisterRegionComplete(int thread_id,
blink::WebGeofencingCallbacks* callbacks =
region_unregistration_requests_.Lookup(request_id);
DCHECK(callbacks);
- if (!callbacks)
- return;
if (status == GEOFENCING_STATUS_OK) {
callbacks->onSuccess();
@@ -189,8 +185,6 @@ void GeofencingDispatcher::OnGetRegisteredRegionsComplete(
blink::WebGeofencingRegionsCallbacks* callbacks =
get_registered_regions_requests_.Lookup(request_id);
DCHECK(callbacks);
- if (!callbacks)
- return;
if (status == GEOFENCING_STATUS_OK) {
scoped_ptr<blink::WebVector<blink::WebGeofencingRegistration>> result(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698