MacViews: Move content::AcceleratedWidget to new component, ui/accelerated_widget_mac

ui/compositor/mac/io_surface_layer_mac.h

Index: ui/compositor/mac/io_surface_layer_mac.h
diff --git a/content/browser/compositor/io_surface_layer_mac.h b/ui/compositor/mac/io_surface_layer_mac.h
similarity index 94%
rename from content/browser/compositor/io_surface_layer_mac.h
rename to ui/compositor/mac/io_surface_layer_mac.h
index 5a218e8f66529e0b94e40ba596d5ea73d3defcfd..aec3a33068ae9df5f2448be7f619e55c00ad3518 100644
--- a/content/browser/compositor/io_surface_layer_mac.h
+++ b/ui/compositor/mac/io_surface_layer_mac.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_COMPOSITOR_IO_SURFACE_LAYER_MAC_H_
-#define CONTENT_BROWSER_COMPOSITOR_IO_SURFACE_LAYER_MAC_H_
+#ifndef UI_COMPOSITOR_MAC_IO_SURFACE_LAYER_MAC_H_
+#define UI_COMPOSITOR_MAC_IO_SURFACE_LAYER_MAC_H_
 
 #import <Cocoa/Cocoa.h>
 
@@ -28,6 +28,10 @@ class IOSurfaceLayerClient {
   // immediately.
   virtual bool IOSurfaceLayerShouldAckImmediately() const = 0;
 

[ccameron, 2014/11/25 17:54:25]

I was wondering if to make the glFinish workaround argument to the creation of
the AcceleratedWidgetMac (then passed down here) versus making it a client
method. The way you went with is probably simpler (either way it's
somewhat-odd-plumbing).

[tapted, 2014/11/25 23:53:55]

re: odd plumbing: Ash faces a similar problem (i.e. injecting
content::GpuDataManager), which is solved by ash::GPUSupport and
ShellDelegateImpl::CreateGPUSupport().

I like the idea of an argument to AcceleratedWidgetMac - that way it can be fed
in through views::ViewsDelegate, which can be provided from chrome-land since it
has the content dependency already. Then we're following a similar pattern to
Ash.

Done.

+  // Whether the IOSurface should use the glFinish() workaround after
+  // compositing.
+  virtual bool IOSurfaceNeedsGLFinishWorkaround() const = 0;
+
   // Called when a frame is drawn or when, because the layer is not visible, it
   // is known that the frame will never drawn.
   virtual void IOSurfaceLayerDidDrawFrame() = 0;
@@ -158,4 +162,4 @@ class IOSurfaceLayerHelper {
 - (void)endPumpingFrames;
 @end
 
-#endif  // CONTENT_BROWSER_COMPOSITOR_IO_SURFACE_LAYER_MAC_H_
+#endif  // UI_COMPOSITOR_MAC_IO_SURFACE_LAYER_MAC_H_