MacViews: Move content::AcceleratedWidget to new component, ui/accelerated_widget_mac

ui/compositor/mac/io_surface_layer_mac.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_COMPOSITOR_IO_SURFACE_LAYER_MAC_H_
-#define CONTENT_BROWSER_COMPOSITOR_IO_SURFACE_LAYER_MAC_H_
+#ifndef UI_COMPOSITOR_MAC_IO_SURFACE_LAYER_MAC_H_
+#define UI_COMPOSITOR_MAC_IO_SURFACE_LAYER_MAC_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/memory/ref_counted.h"
 #include "base/timer/timer.h"
 #include "ui/gfx/size.h"
 
 @class IOSurfaceLayer;
 
 namespace content {
 class IOSurfaceTexture;
 class IOSurfaceContext;
 
 // The interface through which the IOSurfaceLayer calls back into
 // the structrue that created it (RenderWidgetHostViewMac or
 // BrowserCompositorViewMac).
 class IOSurfaceLayerClient {
  public:
   // Used to indicate that the layer should attempt to draw immediately and
   // should (even if the draw is elided by the system), ack the frame
   // immediately.
   virtual bool IOSurfaceLayerShouldAckImmediately() const = 0;
 

[ccameron, 2014/11/25 17:54:25]

I was wondering if to make the glFinish workaround argument to the creation of
the AcceleratedWidgetMac (then passed down here) versus making it a client
method. The way you went with is probably simpler (either way it's
somewhat-odd-plumbing).

[tapted, 2014/11/25 23:53:55]

re: odd plumbing: Ash faces a similar problem (i.e. injecting
content::GpuDataManager), which is solved by ash::GPUSupport and
ShellDelegateImpl::CreateGPUSupport().

I like the idea of an argument to AcceleratedWidgetMac - that way it can be fed
in through views::ViewsDelegate, which can be provided from chrome-land since it
has the content dependency already. Then we're following a similar pattern to
Ash.

Done.

+  // Whether the IOSurface should use the glFinish() workaround after
+  // compositing.
+  virtual bool IOSurfaceNeedsGLFinishWorkaround() const = 0;
+
   // Called when a frame is drawn or when, because the layer is not visible, it
   // is known that the frame will never drawn.
   virtual void IOSurfaceLayerDidDrawFrame() = 0;
 
   // Called when an error prevents the frame from being drawn.
   virtual void IOSurfaceLayerHitError() = 0;
 };
 
 // IOSurfaceLayerHelper provides C++ functionality needed for the
 // IOSurfaceLayer class, and does most of the heavy lifting for the
@@ skipping 110 matching lines @@
 
 // Force a draw immediately, but only if one was requested.
 - (void)displayIfNeededAndAck;
 
 // Mark a bracket in which new frames are being pumped in a restricted nested
 // run loop.
 - (void)beginPumpingFrames;
 - (void)endPumpingFrames;
 @end
 
-#endif  // CONTENT_BROWSER_COMPOSITOR_IO_SURFACE_LAYER_MAC_H_
+#endif  // UI_COMPOSITOR_MAC_IO_SURFACE_LAYER_MAC_H_