Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 75383002: Avoid silly crash in ContextFeatures::urlDidChange (Closed)

Created:
7 years, 1 month ago by sigbjorn
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid silly crash in ContextFeatures::urlDidChange BUG=294180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/core/dom/ContextFeatures.h View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sigbjorn
This should be simple enough to review. Avoid silly crash for now, leave fixing the ...
7 years, 1 month ago (2013-11-18 15:36:57 UTC) #1
sigbjorn
morrita, would you be able to review this?
7 years ago (2013-11-28 14:51:46 UTC) #2
Hajime Morrita
lgtm. Thanks for the fix. This means urlDidChange() hasn't been working :-(
7 years ago (2013-11-29 00:28:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjorn@opera.com/75383002/1
7 years ago (2013-11-29 08:27:52 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-29 09:58:40 UTC) #5
Message was sent while issue was closed. 
Change committed as 162884

Powered by Google App Engine
This is Rietveld 408576698