Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: Source/core/dom/ContextFeatures.h

Issue 75383002: Avoid silly crash in ContextFeatures::urlDidChange (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ContextFeatures.h
diff --git a/Source/core/dom/ContextFeatures.h b/Source/core/dom/ContextFeatures.h
index b3f309fbfe6ba9137dd787babbc5ee9650e1441e..109b781ff09430b53a7191edd8f6e78cbc302e42 100644
--- a/Source/core/dom/ContextFeatures.h
+++ b/Source/core/dom/ContextFeatures.h
@@ -102,9 +102,14 @@ inline bool ContextFeatures::isEnabled(Document* document, FeatureType type, boo
inline void ContextFeatures::urlDidChange(Document* document)
{
- if (m_client)
- return;
- m_client->urlDidChange(document);
+ // FIXME: The original code, commented out below, is obviously
+ // wrong, but the seemingly correct fix of negating the test to
+ // the more logical 'if (!m_client)' crashes the renderer.
+ // See issue 294180
+ //
+ // if (m_client)
+ // return;
+ // m_client->urlDidChange(document);
}
} // namespace WebCore
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698