Input type file should return ButtonRole.

Input type file should return ButtonRole.

Due to changes in this CL https://codereview.chromium.org/718403002/ input type file was affected.
Since after all checks inside html input element, TextFieldRole was returned to chromium. But the check for
input type file was outside the check for html input element.

BUG=418486
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185928

[shreeramk, 2014-11-24 10:11:48]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-11-24 10:11:49]

Please review.

Thanks!!

[dmazzoni, 2014-11-24 17:41:31]

I'm not sure this is right. An input type="file" is a composite of two
RenderObjects: a button (to choose the file), and a text field (showing the name
of the file). Previously this worked correctly - both the button and the text
field were exposed as separate AX objects.

[shreeramk, 2014-11-24 18:12:31]

On 2014/11/24 17:41:31, dmazzoni wrote:
> I'm not sure this is right. An input type="file" is a composite of two
> RenderObjects: a button (to choose the file), and a text field (showing the
name
> of the file). Previously this worked correctly - both the button and the text
> field were exposed as separate AX objects.

This is how it is exposed in input-types.html(which is uneffected one, since it
was disabled when the mentioned blink changed rolled in.)

IA2_ROLE_LABEL
      ROLE_SYSTEM_STATICTEXT name='File: '
      ROLE_SYSTEM_PUSHBUTTON name='Choose File' FOCUSABLE

With my change, I think I ll get the same... isn't??

Anyways, I ll confirm this tomorrow. Today my windows build was very horrible.

[shreeramk, 2014-11-25 05:00:30]

I confirm that with above changes of mine. There is no difference with the prev
AX tree without sideeffect. Same result is coming
AX Tree on chrome:
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
    IA2_ROLE_SECTION READONLY
        ROLE_SYSTEM_PUSHBUTTON name='Choose File' value='No file chosen'
READONLY

From AX tree we can see, the text 'No file chosen' is coming as the value of the
push button.


Aviewr result:

But FireFox behavior is different.
- document
  - input
    - Browser... - push button
    - No file selected - text
      - No file selected - editable text


In chrome

-Document
  - body
    - Choose File - push button


May be this difference is coming due to different implementation of input type
file on chrome and firefox.

[dmazzoni, 2014-11-25 07:35:16]

OK, I can confirm that nothing changes.

I thought this used to work. I just tried adding a file and it didn't
update the AX tree at all, which is definitely wrong.

So your change is okay, but I would like to improve this.

On Mon, Nov 24, 2014 at 9:00 PM, <shreeram.k@samsung.com> wrote:

> I confirm that with above changes of mine. There is no difference with the
> prev
> AX tree without sideeffect. Same result is coming
> AX Tree on chrome:
> ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
>     IA2_ROLE_SECTION READONLY
>         ROLE_SYSTEM_PUSHBUTTON name='Choose File' value='No file chosen'
> READONLY
>
> From AX tree we can see, the text 'No file chosen' is coming as the value
> of the
> push button.
>
>
> Aviewr result:
>
> But FireFox behavior is different.
> - document
>   - input
>     - Browser... - push button
>     - No file selected - text
>       - No file selected - editable text
>
>
> In chrome
>
> -Document
>   - body
>     - Choose File - push button
>
>
> May be this difference is coming due to different implementation of input
> type
> file on chrome and firefox.
>
> https://codereview.chromium.org/753663003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-11-25 07:53:02]

I would like to improve that in a separate patch, because this CL
https://codereview.chromium.org/738733005/ is depends on this. I don't want tht
due to this side effect it introduce other bugs or effect other AX test files.

[dmazzoni, 2014-11-25 07:56:25]

lgtm

[shreeramk, 2014-11-25 08:06:35]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-11-25 08:07:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753663003/1

[commit-bot: I haz the power, 2014-11-25 09:05:17]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185928