Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 753663003: Input type file should return ButtonRole. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXNodeObject.cpp
diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp
index 269e81a68ac453d64ecf20362e459ff6bc229a88..77c965ed5879791b6080e813f1f741ef9c7d699a 100644
--- a/Source/modules/accessibility/AXNodeObject.cpp
+++ b/Source/modules/accessibility/AXNodeObject.cpp
@@ -1534,15 +1534,13 @@ Element* AXNodeObject::actionElement() const
if (isHTMLInputElement(*node)) {
HTMLInputElement& input = toHTMLInputElement(*node);
- if (!input.isDisabledFormControl() && (isCheckboxOrRadio() || input.isTextButton()))
+ if (!input.isDisabledFormControl() && (isCheckboxOrRadio() || input.isTextButton()
+ || input.type() == InputTypeNames::file))
return &input;
} else if (isHTMLButtonElement(*node)) {
return toElement(node);
}
- if (isFileUploadButton())
- return toElement(node);
-
if (AXObject::isARIAInput(ariaRoleAttribute()))
return toElement(node);
« no previous file with comments | « no previous file | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698