base/prefs/mock_pref_change_callback.h - Issue 753603002: Change preference APIs to take std::string instead of const char*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/mock_pref_change_callback.h

Issue 753603002: Change preference APIs to take std::string instead of const char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed all calls to c_str() in prefs. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/mock_pref_change_callback.h

diff --git a/base/prefs/mock_pref_change_callback.h b/base/prefs/mock_pref_change_callback.h

index 422754afd6ee9e7cf7abf6bf3ebc964ab81c9fd9..3030fab17c23c9ed6775e70eee65b45ea6d5295f 100644

--- a/base/prefs/mock_pref_change_callback.h

+++ b/base/prefs/mock_pref_change_callback.h

@@ -19,8 +19,7 @@ using testing::Truly;

// checks that the value is not set.

MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") {

- const PrefService::Preference* pref =

- prefs->FindPreference(pref_name.c_str());

+ const PrefService::Preference* pref = prefs->FindPreference(pref_name);

if (!pref)

return false;

« no previous file with comments | « no previous file | base/prefs/pref_change_registrar.h » ('j') | no next file with comments »