Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: base/prefs/mock_pref_change_callback.h

Issue 753603002: Change preference APIs to take std::string instead of const char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed all calls to c_str() in prefs. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/prefs/pref_change_registrar.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_ 5 #ifndef BASE_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
6 #define BASE_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_ 6 #define BASE_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/prefs/pref_change_registrar.h" 10 #include "base/prefs/pref_change_registrar.h"
11 #include "base/prefs/pref_service.h" 11 #include "base/prefs/pref_service.h"
12 #include "testing/gmock/include/gmock/gmock.h" 12 #include "testing/gmock/include/gmock/gmock.h"
13 13
14 using testing::Pointee; 14 using testing::Pointee;
15 using testing::Property; 15 using testing::Property;
16 using testing::Truly; 16 using testing::Truly;
17 17
18 // Matcher that checks whether the current value of the preference named 18 // Matcher that checks whether the current value of the preference named
19 // |pref_name| in |prefs| matches |value|. If |value| is NULL, the matcher 19 // |pref_name| in |prefs| matches |value|. If |value| is NULL, the matcher
20 // checks that the value is not set. 20 // checks that the value is not set.
21 MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") { 21 MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") {
22 const PrefService::Preference* pref = 22 const PrefService::Preference* pref = prefs->FindPreference(pref_name);
23 prefs->FindPreference(pref_name.c_str());
24 if (!pref) 23 if (!pref)
25 return false; 24 return false;
26 25
27 const base::Value* actual_value = pref->GetValue(); 26 const base::Value* actual_value = pref->GetValue();
28 if (!actual_value) 27 if (!actual_value)
29 return value == NULL; 28 return value == NULL;
30 if (!value) 29 if (!value)
31 return actual_value == NULL; 30 return actual_value == NULL;
32 return value->Equals(actual_value); 31 return value->Equals(actual_value);
33 } 32 }
34 33
35 // A mock for testing preference notifications and easy setup of expectations. 34 // A mock for testing preference notifications and easy setup of expectations.
36 class MockPrefChangeCallback { 35 class MockPrefChangeCallback {
37 public: 36 public:
38 explicit MockPrefChangeCallback(PrefService* prefs); 37 explicit MockPrefChangeCallback(PrefService* prefs);
39 virtual ~MockPrefChangeCallback(); 38 virtual ~MockPrefChangeCallback();
40 39
41 PrefChangeRegistrar::NamedChangeCallback GetCallback(); 40 PrefChangeRegistrar::NamedChangeCallback GetCallback();
42 41
43 MOCK_METHOD1(OnPreferenceChanged, void(const std::string&)); 42 MOCK_METHOD1(OnPreferenceChanged, void(const std::string&));
44 43
45 void Expect(const std::string& pref_name, 44 void Expect(const std::string& pref_name,
46 const base::Value* value); 45 const base::Value* value);
47 46
48 private: 47 private:
49 PrefService* prefs_; 48 PrefService* prefs_;
50 }; 49 };
51 50
52 #endif // BASE_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_ 51 #endif // BASE_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
OLDNEW
« no previous file with comments | « no previous file | base/prefs/pref_change_registrar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698