Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 753373006: Set new blink showContextMenuOnMouseUp setting to true on Windows (Closed)

Created:
6 years ago by zino
Modified:
6 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set new blink showContextMenuOnMouseUp setting to true on Windows Dependency: https://crrev.com/775553002 (blink side) BUG=438544 Committed: https://crrev.com/8f11ffa5be5aad0ccc8a25117b5283a505eaeea4 Cr-Commit-Position: refs/heads/master@{#306774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
zino
Dear Rick, Please take a look.
6 years ago (2014-12-02 18:01:49 UTC) #2
Rick Byers
LGTM (once the blink CL lands and rolls into chromium of course). Note I tweaked ...
6 years ago (2014-12-02 19:35:41 UTC) #3
Rick Byers
On 2014/12/02 19:35:41, Rick Byers wrote: > LGTM (once the blink CL lands and rolls ...
6 years ago (2014-12-02 19:36:20 UTC) #4
zino
Thank you for review. On 2014/12/02 19:36:20, Rick Byers wrote: > On 2014/12/02 19:35:41, Rick ...
6 years ago (2014-12-03 08:26:50 UTC) #5
zino
Dear @Avi, Please take a look. This CL needs your approval for content/*. I'm waiting ...
6 years ago (2014-12-03 12:40:05 UTC) #7
Avi (use Gerrit)
lgtm Good to see we're getting this right.
6 years ago (2014-12-03 16:26:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753373006/1
6 years ago (2014-12-04 02:21:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/94263)
6 years ago (2014-12-04 02:51:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753373006/1
6 years ago (2014-12-04 05:09:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-04 06:03:10 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-04 06:04:44 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f11ffa5be5aad0ccc8a25117b5283a505eaeea4
Cr-Commit-Position: refs/heads/master@{#306774}

Powered by Google App Engine
This is Rietveld 408576698