Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 753233002: Emphasis glyphBuffer to ignore ellipsis when direction is RTL (Closed)

Created:
6 years ago by Habib Virji
Modified:
6 years ago
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid drawing emphasis glyphs over ellipsis marks Accumulate initial advance instead of using "0" non-drawing glyphs. BUG=408544 R=dominik.rottsches@intel.com, behdad TEST=fast/text/emphasis-ellipsis-complextext.html

Patch Set 1 #

Patch Set 2 : Updated TestExpectations for other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/emphasis-ellipsis-complextext.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/text/emphasis-ellipsis-complextext-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/fast/text/emphasis-ellipsis-complextext-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Habib Virji
@Dominik: It is based on previous CL you reviewed: https://codereview.chromium.org/613193002/. I have used advancedSoFar, to ...
6 years ago (2014-11-24 16:47:33 UTC) #1
Dominik Röttsches
Thanks for the update and incorporating the review comments, looks much better. LGTM.
6 years ago (2014-11-24 17:04:56 UTC) #2
Habib Virji
On 2014/11/24 17:04:56, Dominik Röttsches wrote: > Thanks for the update and incorporating the review ...
6 years ago (2014-11-24 17:08:25 UTC) #3
Dominik Röttsches
One thing: Before committing, could you please update the description to be more meaningful and ...
6 years ago (2014-11-24 17:11:34 UTC) #4
Habib Virji
6 years ago (2014-11-24 17:15:46 UTC) #7
On 2014/11/24 17:11:34, Dominik Röttsches wrote:
> One thing: Before committing, could you please update the description to be
more
> meaningful and correct:
> 
> "Avoid drawing emphasis glyphs over ellipsis marks
> 
> Accumulate initial advance instead of using "0" non-drawing glyphs.
> 
> BUG=408544
> mailto:R=dominik.rottsches@intel.com, behdad
> TEST=fast/text/emphasis-ellipsis-complextext.html"

Thanks. Updated.

Powered by Google App Engine
This is Rietveld 408576698