WebRTC: Add fetch recipes to depot_tools.

WebRTC: Add fetch recipes to depot_tools.

For Mac, we're depending on having both ios+mac for target_os.

R=agable@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293085

[kjellander_chromium, 2014-11-24 14:52:00]

kjellander@chromium.org changed reviewers:
+ agable@chromium.org

[kjellander_chromium, 2014-11-24 14:52:01]

This is really slick. Nice work guys!

A single command to setup a workspace; our community will be super-happy.

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc_android.py
File recipes/webrtc_android.py (right):

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc_android.py#ne...
recipes/webrtc_android.py:25: def expected_root(_props):
This one was needed to please pylint.

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc_ios.py
File recipes/webrtc_ios.py (left):

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc_ios.py#oldcode20
recipes/webrtc_ios.py:20: 'props': ['--target_os=ios', '--target_os_only=True'],
We don't use target_os_only for WebRTC.

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc_ios.py
File recipes/webrtc_ios.py (right):

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc_ios.py#newcode25
recipes/webrtc_ios.py:25: def expected_root(_props):
This one was needed to please pylint.

[agable, 2014-11-24 21:21:45]

LGTM! Modulo just a pair of nits.

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc.py
File recipes/webrtc.py (right):

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc.py#newcode18
recipes/webrtc.py:18: solution = { 'name'   :'src',
Please format this more like the one in the infra_internal recipe. I don't know
how this crummy formatting snuck into these recipes in the first place, but I'd
rather not propagate it :)

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc.py#newcode33
recipes/webrtc.py:33: spec_type = '%s_spec' % checkout_type
Similarly, just use spec_type = "gclient_git_svn_spec". The string formatting is
only useful if you support a command line option to either turn on or off
setting up git-svn, like the chromium fetch recipe used to.

[kjellander_chromium, 2014-11-24 21:46:03]

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc.py
File recipes/webrtc.py (right):

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc.py#newcode18
recipes/webrtc.py:18: solution = { 'name'   :'src',
On 2014/11/24 21:21:45, agable wrote:
> Please format this more like the one in the infra_internal recipe. I don't
know
> how this crummy formatting snuck into these recipes in the first place, but
I'd
> rather not propagate it :)

Done.

https://codereview.chromium.org/753123003/diff/1/recipes/webrtc.py#newcode33
recipes/webrtc.py:33: spec_type = '%s_spec' % checkout_type
On 2014/11/24 21:21:45, agable wrote:
> Similarly, just use spec_type = "gclient_git_svn_spec". The string formatting
is
> only useful if you support a command line option to either turn on or off
> setting up git-svn, like the chromium fetch recipe used to.

Done.

[kjellander_chromium, 2014-11-24 21:50:37]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-11-24 21:51:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753123003/20001

[commit-bot: I haz the power, 2014-11-24 21:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-24 21:53:27]

Presubmit check for 753123003-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (109 files) (67.56s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module fix_encoding
E:232, 0: Slice index is not an int, None, or instance with __index__
(invalid-slice-index)
************* Module gclient_scm
E:301,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)
E:1191,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)


Presubmit checks took 105.3s to calculate.

[kjellander_chromium, 2014-11-24 21:59:00]

Committed patchset #2 (id:20001) manually as 293085.