Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: build/config/features.gni

Issue 753103003: Enable external V8 snapshot on Android through GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Ross Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index 9953a0d88e72da1f9375ae4a7260bcb5f13d8a03..4a9a375cfec5dc8d3c7673ede150245ed3c30a39 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -157,3 +157,8 @@ use_brlapi = is_chromeos
# system).
# TODO(GYP) also require !embedded to enable.
use_gconf = is_linux && !is_chromeos
+
+# TODO(baixo) enable this once this lands:
+# https://codereview.chromium.org/749213004
+# v8_use_external_startup_data = is_android && !is_android_webview_build
+v8_use_external_startup_data = false
brettw 2014/11/25 18:50:26 I don't think this should be in "features.gni". I
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698