Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Side by Side Diff: build/config/features.gni

Issue 753103003: Enable external V8 snapshot on Android through GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Ross Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains UI-related build flags. It should theoretically be in the 5 # This file contains UI-related build flags. It should theoretically be in the
6 # src/ui directory and only things that depend on the ui module should get the 6 # src/ui directory and only things that depend on the ui module should get the
7 # definitions. 7 # definitions.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global. 10 # e.g. base, so they need to be global.
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 # ChromeVox, which can then be enabled via a command-line switch. 150 # ChromeVox, which can then be enabled via a command-line switch.
151 enable_chromevox_next = false 151 enable_chromevox_next = false
152 152
153 # Use brlapi from brltty for braille display support. 153 # Use brlapi from brltty for braille display support.
154 use_brlapi = is_chromeos 154 use_brlapi = is_chromeos
155 155
156 # Option controlling the use of GConf (the classic GNOME configuration 156 # Option controlling the use of GConf (the classic GNOME configuration
157 # system). 157 # system).
158 # TODO(GYP) also require !embedded to enable. 158 # TODO(GYP) also require !embedded to enable.
159 use_gconf = is_linux && !is_chromeos 159 use_gconf = is_linux && !is_chromeos
160
161 # TODO(baixo) enable this once this lands:
162 # https://codereview.chromium.org/749213004
163 # v8_use_external_startup_data = is_android && !is_android_webview_build
164 v8_use_external_startup_data = false
brettw 2014/11/25 18:50:26 I don't think this should be in "features.gni". I
OLDNEW
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698