Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Issue 752883002: Revert of [Telemetry] Introduce shared_user_story_state for real. (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
dtu, tonyg, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Introduce shared_user_story_state for real. (patchset #3 id:100001 of https://codereview.chromium.org/733303003/) Reason for revert: Speculative revert BUG=435775 Original issue's description: > [Telemetry] Introduce shared_user_story_state for real. > > Move page.page_runner --> user_story.user_story_runner. > > BUG=418278 > > Committed: https://crrev.com/7f4660dcd4c4476502a61eb7375c4a941d938b9b > Cr-Commit-Position: refs/heads/master@{#305119} TBR=chrishenry@google.com,dtu@chromium.org,tonyg@chromium.org BUG=418278 Committed: https://crrev.com/d22fddcf0ce196758dd659759f14af88d998aa69 Cr-Commit-Position: refs/heads/master@{#305358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -685 lines) Patch
M tools/perf/measurements/page_cycler_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/profile_creators/extensions_profile_creator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials.py View 2 chunks +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/__init__.py View 2 chunks +1 line, -2 lines 0 comments Download
A tools/telemetry/telemetry/page/page_runner.py View 1 chunk +285 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 20 chunks +71 lines, -73 lines 0 comments Download
M tools/telemetry/telemetry/page/profile_generator.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 6 chunks +10 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/user_story/__init__.py View 2 chunks +1 line, -25 lines 0 comments Download
D tools/telemetry/telemetry/user_story/shared_user_story_state.py View 1 chunk +0 lines, -63 lines 0 comments Download
D tools/telemetry/telemetry/user_story/user_story_runner.py View 1 chunk +0 lines, -350 lines 0 comments Download
D tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 1 chunk +0 lines, -117 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_unittest.py View 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of [Telemetry] Introduce shared_user_story_state for real.
6 years, 1 month ago (2014-11-22 04:21:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752883002/1
6 years, 1 month ago (2014-11-22 05:36:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 06:37:07 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 06:37:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d22fddcf0ce196758dd659759f14af88d998aa69
Cr-Commit-Position: refs/heads/master@{#305358}

Powered by Google App Engine
This is Rietveld 408576698