tools/perf/profile_creators/extensions_profile_creator.py - Issue 752883002: Revert of [Telemetry] Introduce shared_user_story_state for real.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/extensions_profile_creator.py

Issue 752883002: Revert of [Telemetry] Introduce shared_user_story_state for real. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/profile_creators/extensions_profile_creator.py

diff --git a/tools/perf/profile_creators/extensions_profile_creator.py b/tools/perf/profile_creators/extensions_profile_creator.py

index 027439b7a8726011b18857d2b7c6682f6e31bb0c..88dbb5715dc6bdd4874477fe88f02befd35b7e61 100644

--- a/tools/perf/profile_creators/extensions_profile_creator.py

+++ b/tools/perf/profile_creators/extensions_profile_creator.py

@@ -206,7 +206,7 @@

# Phase 1: When the first page is loaded: we wait for a timeout to allow

# all extensions to install and to prime safe browsing and other

# caches. Extensions may open tabs as part of the install process.

- # Phase 2: When the second page loads, user_story_runner closes all tabs -

+ # Phase 2: When the second page loads, page_runner closes all tabs -

# we are left with one open tab, wait for that to finish loading.

# Sleep for a bit to allow safe browsing and other data to load +

« no previous file with comments | « tools/perf/measurements/page_cycler_unittest.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »