|
Handle recovery on "timestamp-looking" lines in the WebVTT parser
When a line with a "-->" is encountered as part of cue-text, in the
header part or after a previous error (i.e. during "bad cue" processing).
The parser is supposed to break out of the current state and try to parse
the "-->" line as being the start of a new cue.
Updated testcases:
PASS -> FAIL
tc006, tc007 and tc011 (Tested the old behavior where "-->" was
allowed/ignored, and blank lines were required to start a new cue.)
FAIL -> PASS
opera/track/webvtt/parsing subtests nulls, header-timings, header-space,
header-tab and arrows
opera/interfaces/TextTrackCue/vertical.html
TEST=media/track/track-webvtt-tc031-cue-recovery.html
TEST=media/track/track-webvtt-tc032-degenerate-cues.html
BUG= 305317
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162210
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+174 lines, -35 lines) |
Patch |
|
A + |
LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-cuetext.vtt
|
View
|
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-header.vtt
|
View
|
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
|
A |
LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-note.vtt
|
View
|
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/media/track/captions-webvtt/tc032-degenerate-cues.vtt
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
LayoutTests/media/track/opera/interfaces/VTTCue/vertical-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/media/track/track-webvtt-tc007-cue-no-id-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/media/track/track-webvtt-tc011-blank-lines-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A |
LayoutTests/media/track/track-webvtt-tc031-cue-recovery.html
|
View
|
|
1 chunk |
+63 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/media/track/track-webvtt-tc031-cue-recovery-expected.txt
|
View
|
|
1 chunk |
+31 lines, -0 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html
|
View
|
|
2 chunks |
+13 lines, -8 lines |
0 comments
|
Download
|
|
A |
LayoutTests/media/track/track-webvtt-tc032-degenerate-cues-expected.txt
|
View
|
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/track/vtt/VTTParser.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/track/vtt/VTTParser.cpp
|
View
|
|
3 chunks |
+27 lines, -3 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|