LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html - Issue 75273002: Handle recovery on "timestamp-looking" lines in the WebVTT parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html

Issue 75273002: Handle recovery on "timestamp-looking" lines in the WebVTT parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/track/track-webvtt-tc031-cue-recovery-expected.txt ('k') | LayoutTests/media/track/track-webvtt-tc032-degenerate-cues-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html

diff --git a/LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue.html b/LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html

similarity index 63%

copy from LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue.html

copy to LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html

index ab8d206623917a4344ff6ff005583c7ec2889840..9fc7f742e7112d5b41e613578e84e3c6abc7668c 100644

--- a/LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue.html

+++ b/LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html

@@ -22,19 +22,24 @@

findMediaElement();

var expected =

{

- length: 2,

+ length: 3,

tests:

[

{

+ property: "startTime",

+ values: [ "0", "2", "4" ],

+ },

+ {

+ property: "endTime",

+ values: [ "1", "3", "5" ],

+ },

+ {

property: "text",

- values:

- [

- 'First',

- 'Second',

- ],

+ values: [ '', '', '' ],

};

testCues(0, expected);

allTestsEnded();

@@ -42,9 +47,9 @@

</script>

</head>

- <p>Tests that an empty line after an identifier line discards the current cue and restarts the cue loop.</p>

+ <p>Tests that a degenerate cues without separating blank lines are parsed correctly.</p>

<video>

- <track src="captions-webvtt/tc030-interspersed-non-cue.vtt" onload="trackLoaded()">

+ <track src="captions-webvtt/tc032-degenerate-cues.vtt" onload="trackLoaded()">

</video>

</body>

</html>