Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 752623002: Fix error in Ganesh' tiled bitmap drawing (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix error in Ganesh' tiled bitmap drawing When the paint filter level is high ShouldUseBicubic doesn't always return true. In this case the paint's filter level will differ from the filtering Ganesh will use. This was leading to a mismatch between the tiling computed in SkGpuDevice::drawBitmapCommon and the one in SkGpuDevice::drawTiledBitmap. The end result of this was that the max texture restriction could be violated which is currently being seen on the Xoom & N7 bots. Both of them have a max texture size of 2048 which is invoking the tiled drawbitmap case. Committed: https://skia.googlesource.com/skia/+/ec8bb946c37ace5d1ac76dfb56a9fc4be4fb142e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
6 years, 1 month ago (2014-11-21 17:18:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752623002/1
6 years, 1 month ago (2014-11-21 17:26:29 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-21 17:26:31 UTC) #5
humper
On 2014/11/21 17:26:31, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
6 years, 1 month ago (2014-11-21 17:34:13 UTC) #6
bsalomon
lgtm
6 years, 1 month ago (2014-11-21 18:15:57 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 18:16:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ec8bb946c37ace5d1ac76dfb56a9fc4be4fb142e

Powered by Google App Engine
This is Rietveld 408576698