chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc - Issue 752153005: Reset singleton ZoomBubbleView::zoom_bubble_ in ::Close()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Issue 752153005: Reset singleton ZoomBubbleView::zoom_bubble_ in ::Close() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2214

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

index a8068ba79351d41211ff8484834ace87538052f4..e76c8cc737ee329a10497e20ab6df43f7164c033 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

@@ -95,7 +95,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, ImmersiveFullscreen) {

immersive_controller->GetRevealedLock(

ImmersiveModeController::ANIMATE_REVEAL_NO));

ASSERT_TRUE(immersive_controller->IsRevealed());

- EXPECT_TRUE(ZoomBubbleView::zoom_bubble_->GetWidget()->IsClosed());

+ EXPECT_EQ(NULL, ZoomBubbleView::zoom_bubble_);

// The zoom bubble should be anchored when it is shown in immersive fullscreen

// and the top-of-window views are revealed.

« no previous file with comments | « chrome/browser/ui/views/location_bar/zoom_bubble_view.cc ('k') | no next file » | no next file with comments »