Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 752153005: Reset singleton ZoomBubbleView::zoom_bubble_ in ::Close() (Closed)

Created:
6 years ago by wjmaclean
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Reset singleton ZoomBubbleView::zoom_bubble_ in ::Close() The current implementation of ZoomBubbleView is capable of attempting to re-use a zoom bubble with a stale WebContents*. This CL resets ZoomBubbleView::zoom_bubble_ in the ZoomBubbleView::Close() method to avoid inadvertent reuse. It also adds a DCHECK to make sure WebContents* are never mis-matched in calls to ZoomBubbleView::ShowBubble(). BUG=428561 Review URL: https://codereview.chromium.org/712993004 Cr-Commit-Position: refs/heads/master@{#303945} (cherry picked from commit d1b6f4d89d002808689a156b739f8d7fd80104fb) TBR=wjmaclean

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
wjmaclean
6 years ago (2014-11-25 13:53:22 UTC) #1
Message was sent while issue was closed.
Merged manually to branch 2214.

Powered by Google App Engine
This is Rietveld 408576698