Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 751813002: Fix implicit conversion of scoped_refptr<T> to T* in PasswordStoreWin. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix implicit conversion of scoped_refptr<T> to T* in PasswordStoreWin. Since PasswordStoreWin::DBHandler ends up retaining a reference, indicate this by passing a scoped_refptr<PasswordWebDataService>. BUG=110610 Committed: https://crrev.com/edf0e997843feaed395372eb8fcef402c1bebf18 Cr-Commit-Position: refs/heads/master@{#305367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/password_manager/password_store_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dcheng
6 years, 1 month ago (2014-11-22 05:46:00 UTC) #2
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-22 06:16:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751813002/1
6 years, 1 month ago (2014-11-22 06:18:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/78352)
6 years, 1 month ago (2014-11-22 07:30:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751813002/1
6 years, 1 month ago (2014-11-22 07:38:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/78370)
6 years, 1 month ago (2014-11-22 08:49:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751813002/1
6 years, 1 month ago (2014-11-22 17:40:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 18:14:11 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 18:14:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edf0e997843feaed395372eb8fcef402c1bebf18
Cr-Commit-Position: refs/heads/master@{#305367}

Powered by Google App Engine
This is Rietveld 408576698