Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/password_manager/password_store_win.cc

Issue 751813002: Fix implicit conversion of scoped_refptr<T> to T* in PasswordStoreWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/password_store_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_store_win.cc
diff --git a/chrome/browser/password_manager/password_store_win.cc b/chrome/browser/password_manager/password_store_win.cc
index 08af256ea019a9b6a2ff6a6111cd16ba18d8e20d..e2c5d6aa1518bcb4d793d25a8f1bb7a41d3cf4e5 100644
--- a/chrome/browser/password_manager/password_store_win.cc
+++ b/chrome/browser/password_manager/password_store_win.cc
@@ -24,11 +24,9 @@ using password_manager::PasswordStoreDefault;
// Handles requests to PasswordWebDataService.
class PasswordStoreWin::DBHandler : public WebDataServiceConsumer {
public:
- DBHandler(PasswordWebDataService* web_data_service,
+ DBHandler(const scoped_refptr<PasswordWebDataService>& web_data_service,
PasswordStoreWin* password_store)
- : web_data_service_(web_data_service),
- password_store_(password_store) {
- }
+ : web_data_service_(web_data_service), password_store_(password_store) {}
~DBHandler();
@@ -176,7 +174,7 @@ PasswordStoreWin::PasswordStoreWin(
scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,
scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,
password_manager::LoginDatabase* login_database,
- PasswordWebDataService* web_data_service)
+ const scoped_refptr<PasswordWebDataService>& web_data_service)
: PasswordStoreDefault(main_thread_runner,
db_thread_runner,
login_database) {
« no previous file with comments | « chrome/browser/password_manager/password_store_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698