Issue 7518012: Revert 94350 - Merge 94322 - Rewire the metrics pref to the signed settings store on chromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7518012: Revert 94350 - Merge 94322 - Rewire the metrics pref to the signed settings store on chromeos. (Closed)

Created:
9 years, 4 months ago by oritm%chromium.org

Modified:
9 years, 4 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/835/src/

Visibility:
Public.

Revert 94350 - Merge 94322 - Rewire the metrics pref to the signed settings store on chromeos. It used to check the consent file "Consent To Send Stats" which is insecure and does not respect cloud policies. The file is still used but only to store the install GUID. BUG=chromium-os:15188 TEST=Manually - set the policy on the server and verify that the UI reacts correctly. Also the owner should be able to change it. Review URL: http://codereview.chromium.org/7480040 TBR=pastarmovj@chromium.org Review URL: http://codereview.chromium.org/7524002 TBR=pastarmovj@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94789

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -87 lines)			Patch
M	chrome/browser/browser_main.cc	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings.cc	View	2 chunks	+5 lines, -21 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	3 chunks	+3 lines, -25 lines	0 comments	Download
A +	chrome/browser/chromeos/metrics_cros_settings_provider.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/chromeos/metrics_cros_settings_provider.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.cc	View	9 chunks	+2 lines, -32 lines	0 comments	Download
M	chrome/browser/ui/webui/crashes_ui.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/stats_options_handler.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/stats_options_handler.cc	View	3 chunks	+23 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)