Issue 7480040: Rewire the metrics pref to the signed settings store on chromeos.

Issue 7480040: Rewire the metrics pref to the signed settings store on chromeos. (Closed)

Created:
9 years, 5 months ago by pastarmovj

Modified:
9 years, 4 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rewire the metrics pref to the signed settings store on chromeos. It used to check the consent file "Consent To Send Stats" which is insecure and does not respect cloud policies. The file is still used but only to store the install GUID. BUG=chromium-os:15188 TEST=Manually - set the policy on the server and verify that the UI reacts correctly. Also the owner should be able to change it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94322

Patch Set 1 #

Patch Set 2 : Fixed the initial metrics setting from the EULA screen. #

Total comments: 2

Patch Set 3 : Fixed the nit. #

Patch Set 4 : Rebased to ToT. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -166 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 2 3	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings.cc	View		2 chunks	+21 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1	3 chunks	+25 lines, -3 lines	0 comments	Download
D	chrome/browser/chromeos/metrics_cros_settings_provider.h	View		1 chunk	+0 lines, -39 lines	0 comments	Download
D	chrome/browser/chromeos/metrics_cros_settings_provider.cc	View		1 chunk	+0 lines, -83 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.cc	View	1	9 chunks	+32 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/crashes_ui.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/stats_options_handler.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/stats_options_handler.cc	View		3 chunks	+3 lines, -23 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Can you please have a look at this one. It is the same CL like ...

9 years, 4 months ago (2011-07-27 15:43:21 UTC) #1

Mattias Nissler (ping if slow)

LGTM with a nit http://codereview.chromium.org/7480040/diff/2001/chrome/browser/ui/webui/crashes_ui.cc File chrome/browser/ui/webui/crashes_ui.cc (right): http://codereview.chromium.org/7480040/diff/2001/chrome/browser/ui/webui/crashes_ui.cc#newcode31 chrome/browser/ui/webui/crashes_ui.cc:31: #include "chrome/browser/chromeos/cros_settings_names.h" still need this ...

9 years, 4 months ago (2011-07-27 16:10:34 UTC) #2

pastarmovj

9 years, 4 months ago (2011-07-27 16:25:09 UTC) #3

Fixed the nit. I will commit that tomorrow morning so that I can observe the
official bots myself.

http://codereview.chromium.org/7480040/diff/2001/chrome/browser/ui/webui/cras...
File chrome/browser/ui/webui/crashes_ui.cc (right):

http://codereview.chromium.org/7480040/diff/2001/chrome/browser/ui/webui/cras...
chrome/browser/ui/webui/crashes_ui.cc:31: #include
"chrome/browser/chromeos/cros_settings_names.h"
On 2011/07/27 16:10:34, Mattias Nissler wrote:
> still need this include?

Done.

Expand Messages | Collapse Messages