Issue 751713002: Revert of Add -ftrapv to debug builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 751713002: Revert of Add -ftrapv to debug builds. (Closed)

Created:
6 years, 1 month ago by mtklein

Modified:
6 years, 1 month ago

Reviewers:
bungeman-skia, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of https://codereview.chromium.org/702893003/) Reason for revert: Not clean yet. Original issue's description: > Add -ftrapv to debug builds. > > This adds instrumentation to check that signed integers never under- or > overflow, which is undefined behavior. > > BUG=skia:3096 > > Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3096 Committed: https://skia.googlesource.com/skia/+/c0591ca026144230f08b0c8d2c9b8f47e039fca4

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	gyp/common_conditions.gypi	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751713002/1

6 years, 1 month ago (2014-11-21 22:42:31 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-21 22:42:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c0591ca026144230f08b0c8d2c9b8f47e039fca4