Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/common_conditions.gypi

Issue 751713002: Revert of Add -ftrapv to debug builds. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index bb6bad560d81dd36c13b0d6873ad2c587c7a5664..d9c048771e0b75373fc2fbbb02224887684a5096 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -398,7 +398,6 @@
'ldflags': ['--coverage'],
},
'Debug': {
- 'cflags': ['-ftrapv'], # Crash on signed integer over/underflow.
},
'Release': {
'cflags': [
@@ -579,7 +578,7 @@
],
'configurations': {
'Debug': {
- 'cflags': ['-g', '-ftrapv']
+ 'cflags': ['-g']
},
'Release': {
'cflags': ['-O2'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698