Implemented consumer management unenrollment.

Implemented consumer management unenrollment.

To implement this feature:
  - Added ConsumerUnenrollmentHandler and ConsumerUnenrollmentHandlerFactory.
  - Added DevcieCloudPolicyManagerChromeOS::Unregister() and Disconnect().
  - Added CloudPolicyService::Unregister().
  - Added unenrollment related stages in ConsumerManagementStage.
  - Extended ConsumerManagementNotification to show unenroll notifications.

Also, the device cloud policy initializer is restarted after the unenrollment
so that we can implement reboot-free enrollment in the future. To implement
this feature:
  - Added OnDeviceCloudPolicyManagerDisconnected().
  - Added BrowserPolicyConnectChromeOS::RestartDeviceCloudPolicyInitializer()
  - Fixed the initiailzer so that it uses ConsumerManagementService to check if
    the device is consumer-managed rather using DeviceCloudPolicyStore, which
    doesn't load policies for consumer-managed devices.

BUG=chromium:353050
TEST=unit_tests

Committed: https://crrev.com/051ed4f27b9361534e25311ad1987f30335faa16
Cr-Commit-Position: refs/heads/master@{#311643}

Committed: https://crrev.com/79b7fad5012d359381a0b57bdbf32b866de8ad4e
Cr-Commit-Position: refs/heads/master@{#312170}

[davidyu, 2014-11-22 15:16:13]

davidyu@chromium.org changed reviewers:
+ bartfab@chromium.org, mnissler@chromium.org

[davidyu, 2014-11-22 15:16:14]

Note that the notification UI does not quite match the mock. I'll update the UI
to match the mock later.

[bartfab (slow), 2014-11-28 13:25:19]

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h:144: //
registration status is changed from registered to unregistered.
Nit: s/is //

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:82:
EXPECT_FALSE(HasEnrollmentNotification());
Nit: Add a check to verify that the unenrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:87:
EXPECT_TRUE(HasEnrollmentNotification());
Nit: Add a check to verify that the unenrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:95:
EXPECT_FALSE(HasUnenrollmentNotification());
Nit: Add a check to verify that the enrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:100:
EXPECT_TRUE(HasUnenrollmentNotification());
Nit: Add a check to verify that the enrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:113:
EXPECT_FALSE(HasEnrollmentNotification());
Nit: Add a check to verify that the unenrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:119:
EXPECT_TRUE(HasEnrollmentNotification());
Nit: Add a check to verify that the unenrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:129:
EXPECT_FALSE(HasUnenrollmentNotification());
Nit: Add a check to verify that the enrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:134:
EXPECT_FALSE(HasUnenrollmentNotification());
Nit: Add a check to verify that the enrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:140:
EXPECT_TRUE(HasUnenrollmentNotification());
Nit: Add a check to verify that the enrollment notification was not triggered.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_management_service.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_service.cc:99: Status status
= GetStatus();
Nit: Const.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_management_service.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_service.h:102: // A
convenient method that returns true if the status is enrolled or
Nit: s/convenient/convenience/

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:9: #include
"chrome/browser/browser_process.h"
Nit: Not used.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:10: #include
"chrome/browser/browser_process_platform_part.h"
Nit: Not used.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:11: #include
"chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
Nit: Not used.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:39:
device_cloud_policy_manager_->Unregister(
What if the user clicks the "unenroll" button again while unenrollment is still
in progress? This class should have a member that indicates whether unenrollment
is currently in progress and makes it ignore any further Start() calls during
that time.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.h:21: //
ConsumerUnenrollmentHandler unenrolls the device from consumer management
Nit: s/from/from the/

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.h:31: void
Shutdown() override;
Why do you override this method?

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc:13:
#include "content/public/browser/browser_context.h"
Nit: You never dereference any BrowserContexts.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc:62:
base::MessageLoopProxy::current()));
Nit: Here and below: MessageLoopProxy is deprecated. Use
base::ThreadTaskRunnerHandle::Get() instead.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc:69:
EXPECT_EQ(chromeos::DeviceSettingsService::STORE_SUCCESS,
Nit: #include "chrome/browser/chromeos/settings/device_settings_service.h"

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:30: //
Initializer is deleted after the manager is connected.
Nit: s/after the manager is connected/when the manager connects/

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:31:
connector->GetDeviceCloudPolicyManager()->StartConnection(
Nit: #include
"chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:36: //
Initializer is restarted after the manager is disconnected.
Nit: s/after the manager is disconnected/when the manager disconnects/

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc:240:
DeviceManagementService* service = NULL;
Nit: s/NULL/nullptr/

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc:253:
core()->Disconnect();
Nit: #include "components/policy/core/common/cloud/cloud_policy_core.h"

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:45: //
Invoked when the device cloud policy manager is disconnected.
Nit: s/is disconnected/disconnects/

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:94:
virtual void Unregister(const base::Callback<void(bool)>& callback);
Nit: If you define a type for this callback, the fake implementation will be
able to reference it instead of repeating the whole |const
base::Callback<void(bool)>|.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:280:
ConsumerManagementService::STATUS_ENROLLED,
Nit: #include "chrome/browser/chromeos/policy/consumer_management_service.h"

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:281:
ConsumerManagementStage(ConsumerManagementStage::NONE));
Nit: #include "chrome/browser/chromeos/policy/consumer_management_stage.h"

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:288:
EXPECT_FALSE(manager_->core()->service());  // Not connected.
Nit: #include "components/policy/core/common/cloud/cloud_policy_core.h"

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc:25:
NULL),  // consumer_management_service
Nit: s/NULL/nullptr/ (feel free to replace the NULLs above while you are at it)

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h:8: #include
"base/callback.h"
Nit: Move this include to the implementation file. It is customary to not
include dependencies for overridden methods in the header.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h:29: void
Unregister(
Nit: Add comment:

// DeviceCloudPolicyManagerChromeOS:

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/settings/device_settings_service.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/settings/device_settings_service.cc:176: if
(device_id.empty())
Nit: I think it would be more readable if you added a blank line above this.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_service.cc (right):

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service.cc:69:
unregister_callback_ = callback;
What if there already is an unregistration in progress? How about calling
unregister_callback_.Run(false); before overwriting it with the new callback?

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service.cc:174:
unregister_callback_.Run(success);
Nit: Reset the callback after running it. This will ensure that if someone binds
a refcounted object to the callback, the reference is dropped.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_service.h (right):

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service.h:34: typedef
base::Callback<void(bool)> UnregisterCallback;
Nit: Use C++11 using = instead of typedef.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_service_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service_unittest.cc:219:
base::Unretained(this)));
Nit: #include "base/bind_helpers.h"

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service_unittest.cc:232:
TEST_F(CloudPolicyServiceTest, UnregisterRevokesAllOnGoingPolicyRefresh) {
Nit: s/Refresh/Refreshes/

[davidyu, 2014-12-01 14:51:07]

Patchset #4 (id:60001) has been deleted

[davidyu, 2014-12-01 17:05:23]

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h:144: //
registration status is changed from registered to unregistered.
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: s/is //

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:82:
EXPECT_FALSE(HasEnrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the unenrollment notification was not
triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:87:
EXPECT_TRUE(HasEnrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the unenrollment notification was not
triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:95:
EXPECT_FALSE(HasUnenrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the enrollment notification was not triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:100:
EXPECT_TRUE(HasUnenrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the enrollment notification was not triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:113:
EXPECT_FALSE(HasEnrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the unenrollment notification was not
triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:119:
EXPECT_TRUE(HasEnrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the unenrollment notification was not
triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:129:
EXPECT_FALSE(HasUnenrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the enrollment notification was not triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:134:
EXPECT_FALSE(HasUnenrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the enrollment notification was not triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc:140:
EXPECT_TRUE(HasUnenrollmentNotification());
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Add a check to verify that the enrollment notification was not triggered.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_management_service.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_service.cc:99: Status status
= GetStatus();
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Const.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_management_service.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_management_service.h:102: // A
convenient method that returns true if the status is enrolled or
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: s/convenient/convenience/

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:9: #include
"chrome/browser/browser_process.h"
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Not used.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:10: #include
"chrome/browser/browser_process_platform_part.h"
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Not used.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:11: #include
"chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
On 2014/11/28 13:25:17, bartfab wrote:
> Nit: Not used.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc:39:
device_cloud_policy_manager_->Unregister(
On 2014/11/28 13:25:18, bartfab wrote:
> What if the user clicks the "unenroll" button again while unenrollment is
still
> in progress? This class should have a member that indicates whether
unenrollment
> is currently in progress and makes it ignore any further Start() calls during
> that time.

When the user clicks the unenroll button, it immediately changes the stage and
the option page, which observes the status change, will change the button to
"unenrolling" and disabled. In the current implementation it is safe and will
not have race condition, but I can add some sanity check here in case the code
gets refactored later.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.h:21: //
ConsumerUnenrollmentHandler unenrolls the device from consumer management
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: s/from/from the/

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler.h:31: void
Shutdown() override;
On 2014/11/28 13:25:18, bartfab wrote:
> Why do you override this method?

Deleted.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc:13:
#include "content/public/browser/browser_context.h"
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: You never dereference any BrowserContexts.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc:62:
base::MessageLoopProxy::current()));
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: Here and below: MessageLoopProxy is deprecated. Use
> base::ThreadTaskRunnerHandle::Get() instead.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc:69:
EXPECT_EQ(chromeos::DeviceSettingsService::STORE_SUCCESS,
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: #include "chrome/browser/chromeos/settings/device_settings_service.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:30: //
Initializer is deleted after the manager is connected.
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: s/after the manager is connected/when the manager connects/

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:31:
connector->GetDeviceCloudPolicyManager()->StartConnection(
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: #include
> "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc:36: //
Initializer is restarted after the manager is disconnected.
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: s/after the manager is disconnected/when the manager disconnects/

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc:240:
DeviceManagementService* service = NULL;
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: s/NULL/nullptr/

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc:253:
core()->Disconnect();
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: #include "components/policy/core/common/cloud/cloud_policy_core.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:45: //
Invoked when the device cloud policy manager is disconnected.
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: s/is disconnected/disconnects/

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h:94:
virtual void Unregister(const base::Callback<void(bool)>& callback);
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: If you define a type for this callback, the fake implementation will be
> able to reference it instead of repeating the whole |const
> base::Callback<void(bool)>|.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:280:
ConsumerManagementService::STATUS_ENROLLED,
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: #include "chrome/browser/chromeos/policy/consumer_management_service.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:281:
ConsumerManagementStage(ConsumerManagementStage::NONE));
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: #include "chrome/browser/chromeos/policy/consumer_management_stage.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:288:
EXPECT_FALSE(manager_->core()->service());  // Not connected.
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: #include "components/policy/core/common/cloud/cloud_policy_core.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc:25:
NULL),  // consumer_management_service
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: s/NULL/nullptr/ (feel free to replace the NULLs above while you are at
it)

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h:8: #include
"base/callback.h"
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: Move this include to the implementation file. It is customary to not
> include dependencies for overridden methods in the header.

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h:29: void
Unregister(
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: Add comment:
> 
> // DeviceCloudPolicyManagerChromeOS:

Done.

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/settings/device_settings_service.cc (right):

https://codereview.chromium.org/751703003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/settings/device_settings_service.cc:176: if
(device_id.empty())
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: I think it would be more readable if you added a blank line above this.

Done.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_service.cc (right):

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service.cc:69:
unregister_callback_ = callback;
On 2014/11/28 13:25:18, bartfab wrote:
> What if there already is an unregistration in progress? How about calling
> unregister_callback_.Run(false); before overwriting it with the new callback?

Done.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service.cc:174:
unregister_callback_.Run(success);
On 2014/11/28 13:25:18, bartfab wrote:
> Nit: Reset the callback after running it. This will ensure that if someone
binds
> a refcounted object to the callback, the reference is dropped.

Done.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_service.h (right):

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service.h:34: typedef
base::Callback<void(bool)> UnregisterCallback;
On 2014/11/28 13:25:19, bartfab wrote:
> Nit: Use C++11 using = instead of typedef.

Done.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_service_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service_unittest.cc:219:
base::Unretained(this)));
On 2014/11/28 13:25:19, bartfab wrote:
> Nit: #include "base/bind_helpers.h"

Done.

https://codereview.chromium.org/751703003/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_service_unittest.cc:232:
TEST_F(CloudPolicyServiceTest, UnregisterRevokesAllOnGoingPolicyRefresh) {
On 2014/11/28 13:25:19, bartfab wrote:
> Nit: s/Refresh/Refreshes/

Done.

[bartfab (slow), 2014-12-15 15:35:50]

lgtm

https://codereview.chromium.org/751703003/diff/200001/chrome/browser/chromeos...
File
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/200001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:23:
#include "chrome/browser/chromeos/policy/fake_consumer_management_service.h"
Nit: No longer used.

[davidyu, 2014-12-26 08:17:19]

https://codereview.chromium.org/751703003/diff/200001/chrome/browser/chromeos...
File
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/751703003/diff/200001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:23:
#include "chrome/browser/chromeos/policy/fake_consumer_management_service.h"
On 2014/12/15 15:35:50, bartfab (OOO till 7th January) wrote:
> Nit: No longer used.

Done.

[davidyu, 2014-12-30 08:07:23]

davidyu@chromium.org changed reviewers:
+ ygorshenin@chromium.org

[davidyu, 2014-12-30 08:08:36]

davidyu@chromium.org changed reviewers:
+ stevenjb@chromium.org

[davidyu, 2014-12-30 08:09:52]

Hi Yuri, can you please review files under ownership/*?

Hi Steven, can you please review chrome/browser/ui/webui/options/chromeos/*? 

Thanks!

[stevenjb (google-dont-use), 2014-12-30 17:29:14]

stevenjb@google.com changed reviewers:
+ stevenjb@google.com

[stevenjb (google-dont-use), 2014-12-30 17:29:15]

consumer_management_handler.cc lgtm

[davidyu, 2015-01-12 08:49:46]

On 2014/12/30 17:29:15, stevenjb (google-dont-use) wrote:
> consumer_management_handler.cc lgtm

yuri, ping

[ygorshenin1, 2015-01-12 10:08:55]

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/fake_owner_settings_service.cc (right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/fake_owner_settings_service.cc:12: :
OwnerSettingsServiceChromeOS(NULL, profile, owner_key_util),
nit: could you please replace NULL by nullptr?

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/fake_owner_settings_service.h (right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/fake_owner_settings_service.h:31: const
ManagementSettings& last_settings() {
nit: could you please mark the method as const?

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
(right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc:335:
LOG(ERROR) << "===== profile = " << profile;
Could you please replace these two error messages by something like:

LOG(ERROR) << "Profile mismatch: expected=" << profile_ << ", actual=" <<
profile;

?

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h
(right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h:123: friend
class FakeOwnerSettingsService;
Why do you need this friend declaration?

[davidyu, 2015-01-13 05:43:52]

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/fake_owner_settings_service.cc (right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/fake_owner_settings_service.cc:12: :
OwnerSettingsServiceChromeOS(NULL, profile, owner_key_util),
On 2015/01/12 10:08:55, ygorshenin1 wrote:
> nit: could you please replace NULL by nullptr?

Done.

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/fake_owner_settings_service.h (right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/fake_owner_settings_service.h:31: const
ManagementSettings& last_settings() {
On 2015/01/12 10:08:55, ygorshenin1 wrote:
> nit: could you please mark the method as const?

Done.

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
(right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc:335:
LOG(ERROR) << "===== profile = " << profile;
On 2015/01/12 10:08:55, ygorshenin1 wrote:
> Could you please replace these two error messages by something like:
> 
> LOG(ERROR) << "Profile mismatch: expected=" << profile_ << ", actual=" <<
> profile;
> 
> ?

I'll just remove the debug message that I forgot to remove. Printing the pointer
address doesn't really help much.

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h
(right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h:123: friend
class FakeOwnerSettingsService;
On 2015/01/12 10:08:55, ygorshenin1 wrote:
> Why do you need this friend declaration?

For the constructor.

[ygorshenin1, 2015-01-13 11:56:39]

LGTM

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h
(right):

https://codereview.chromium.org/751703003/diff/240001/chrome/browser/chromeos...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h:123: friend
class FakeOwnerSettingsService;
On 2015/01/13 05:43:52, davidyu wrote:
> On 2015/01/12 10:08:55, ygorshenin1 wrote:
> > Why do you need this friend declaration?
> 
> For the constructor.

Ah, I see. Feel free to mark constructor as protected.

[davidyu, 2015-01-14 07:47:30]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-14 07:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/280001

[commit-bot: I haz the power, 2015-01-14 07:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 07:54:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[davidyu, 2015-01-14 07:56:32]

Hi Steven, can you please LGTM with your chromium.org account? Thanks!

[bartfab (slow), 2015-01-14 09:47:20]

On 2015/01/14 07:56:32, davidyu wrote:
> Hi Steven, can you please LGTM with your http://chromium.org account? Thanks!

If a reviewer accidentally uses the wrong account to approve your CL, I think it
is fair game to TBR him and land.

[stevenjb, 2015-01-14 16:55:26]

On 2015/01/14 09:47:20, bartfab wrote:
> On 2015/01/14 07:56:32, davidyu wrote:
> > Hi Steven, can you please LGTM with your http://chromium.org account?
Thanks!
> 
> If a reviewer accidentally uses the wrong account to approve your CL, I think
it
> is fair game to TBR him and land.

+1 (and sorry about that)
lgtm

[davidyu, 2015-01-15 03:21:02]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-15 03:22:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/300001

[commit-bot: I haz the power, 2015-01-15 04:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 04:18:47]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[davidyu, 2015-01-15 06:42:21]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-15 06:43:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/300001

[commit-bot: I haz the power, 2015-01-15 06:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 06:43:48]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[davidyu, 2015-01-15 07:31:12]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-15 07:31:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/300001

[commit-bot: I haz the power, 2015-01-15 07:33:00]

Committed patchset #15 (id:300001)

[commit-bot: I haz the power, 2015-01-15 07:34:15]

Patchset 15 (id:??) landed as
https://crrev.com/051ed4f27b9361534e25311ad1987f30335faa16
Cr-Commit-Position: refs/heads/master@{#311643}

[ricow1, 2015-01-15 10:03:58]

A revert of this CL (patchset #15 id:300001) has been created in
https://codereview.chromium.org/814123006/ by ricow@google.com.

The reason for reverting is: This seems to be leaking, see:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chrom...
.

[davidyu, 2015-01-16 09:33:20]

On 2015/01/15 10:03:58, ricow1 wrote:
> A revert of this CL (patchset #15 id:300001) has been created in
> https://codereview.chromium.org/814123006/ by mailto:ricow@google.com.
> 
> The reason for reverting is: This seems to be leaking, see:
>
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chrom...
> .

Uploaded Patch Set 16 to fix the memory leakage in
ConsumerUnenrollmentHandlerTest.

[ygorshenin1, 2015-01-16 09:36:33]

lgtm

[bartfab (slow), 2015-01-16 10:06:21]

lgtm

[davidyu, 2015-01-16 13:47:16]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-16 13:47:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/320001

[commit-bot: I haz the power, 2015-01-16 13:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-16 13:51:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[davidyu, 2015-01-18 02:37:09]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-18 02:37:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/340001

[commit-bot: I haz the power, 2015-01-18 04:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-18 04:57:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidyu, 2015-01-19 03:29:15]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2015-01-19 03:30:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/340001

[commit-bot: I haz the power, 2015-01-19 03:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-19 03:30:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Andrew T Wilson (Slow), 2015-01-20 08:43:40]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2015-01-20 08:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751703003/340001

[commit-bot: I haz the power, 2015-01-20 08:45:31]

Committed patchset #17 (id:340001)

[commit-bot: I haz the power, 2015-01-20 08:46:35]

Patchset 17 (id:??) landed as
https://crrev.com/79b7fad5012d359381a0b57bdbf32b866de8ad4e
Cr-Commit-Position: refs/heads/master@{#312170}