Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 751643005: Reland of "Enable inobject double fields unboxing for 64-bit archs." (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland of "Enable inobject double fields unboxing for 64-bit archs."

Patch Set 1 : Original CL #

Patch Set 2 : Fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/objects-visiting.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/layout-descriptor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/layout-descriptor-inl.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 3 chunks +8 lines, -4 lines 1 comment Download
M test/cctest/test-unboxed-doubles.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
PTAL https://codereview.chromium.org/751643005/diff/20001/src/objects-inl.h File src/objects-inl.h (left): https://codereview.chromium.org/751643005/diff/20001/src/objects-inl.h#oldcode7361 src/objects-inl.h:7361: obj->map()->layout_descriptor()->IsFastPointerLayout()) { It is not correct to call ...
6 years ago (2014-11-24 09:32:10 UTC) #2
Toon Verwaest
lgtm
6 years ago (2014-11-24 14:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751643005/20001
6 years ago (2014-11-24 14:05:02 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 14:54:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698