WebRTC Android APK trybot recipe

scripts/slave/recipe_modules/gclient/api.py

Index: scripts/slave/recipe_modules/gclient/api.py
diff --git a/scripts/slave/recipe_modules/gclient/api.py b/scripts/slave/recipe_modules/gclient/api.py
index 80bcec197d99685cf370aa0cbb36895a5d4b30be..9e59233d8ddc553dee559d6305ab88f79f8aaaa8 100644
--- a/scripts/slave/recipe_modules/gclient/api.py
+++ b/scripts/slave/recipe_modules/gclient/api.py
@@ -93,6 +93,13 @@ class GclientApi(recipe_api.RecipeApi):
       if s.revision is not None and s.revision != '':
         revisions.extend(['--revision', '%s@%s' % (s.name, s.revision)])
 
+      # HACK(kjellander): Set the revision for the WebRTC Android APK trybots
+      # here since it doesn't seem to exist a nice way to pass that information
+      # into the recipe_modules/webrtc/gclient_config.py.
+      if s.name == 'src/third_party/webrtc':
+        revisions = ['--revision', 'src/third_party/webrtc@%s' %
+                     self.m.properties.get('revision')]

[iannucci, 2013/11/18 18:49:26]

whoa! *bzzt* :p

(mentioned in chat)

why not just either:

c.solutions[0].custom_deps['src/third_party/webrtc'] = 'url@revision'

  OR

c.solutions[<whatever your new solution is>].revision = <revision>

?

[kjellander_chromium, 2013/11/20 14:29:16]

I agree. I moved it into the recipe.

+
     def parse_got_revision(step_result):
       data = step_result.json.output
       for path, info in data['solutions'].iteritems():