WebRTC Android APK trybot recipe

scripts/slave/recipe_modules/gclient/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 
 def jsonish_to_python(spec, is_top=False):
   ret = ''
   if is_top:  # We're the 'top' level, so treat this dict as a suite.
     ret = '\n'.join(
@@ skipping 75 matching lines @@
         # alternately sets 'revision' to the chromium revision OR the webkit
         # revision. This causes gclient to sync to ancient chromium versions
         # occasionally, which is bad. Key off of the 'project' build_property
         # which seems to be set uniquely on this master.
         if self.m.properties.get('project') == 'webkit':
           s.revision = 'HEAD'
 
       if s.revision is not None and s.revision != '':
         revisions.extend(['--revision', '%s@%s' % (s.name, s.revision)])
 
+      # HACK(kjellander): Set the revision for the WebRTC Android APK trybots
+      # here since it doesn't seem to exist a nice way to pass that information
+      # into the recipe_modules/webrtc/gclient_config.py.
+      if s.name == 'src/third_party/webrtc':
+        revisions = ['--revision', 'src/third_party/webrtc@%s' %
+                     self.m.properties.get('revision')]

[iannucci, 2013/11/18 18:49:26]

whoa! *bzzt* :p

(mentioned in chat)

why not just either:

c.solutions[0].custom_deps['src/third_party/webrtc'] = 'url@revision'

  OR

c.solutions[<whatever your new solution is>].revision = <revision>

?

[kjellander_chromium, 2013/11/20 14:29:16]

I agree. I moved it into the recipe.

+
     def parse_got_revision(step_result):
       data = step_result.json.output
       for path, info in data['solutions'].iteritems():
         # gclient json paths always end with a slash
         path = path.rstrip('/')
         if path in cfg.got_revision_mapping:
           propname = cfg.got_revision_mapping[path]
           step_result.presentation.properties[propname] = info['revision']
 
     if not cfg.GIT_MODE:
@@ skipping 89 matching lines @@
     if self.m.properties.get('top_of_tree_blink'):
       return True
 
     # Normalize slashes to take into account possible Windows paths.
     root = self.m.properties.get('root', '').replace('\\', '/').lower()
 
     if root.endswith('third_party/webkit'):
       return True
 
     return False