Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 751613004: Remove android_clang_dbg from PRESUBMIT.py (Closed)

Created:
6 years, 1 month ago by Sergey Berezin
Modified:
6 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, sheyang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove android_clang_dbg from PRESUBMIT.py This bot is no longer in CQ and is subsumed by android_clang_dbg_recipe. It is a waste of resources to run two bots by default. Also, we are bringing up a replacement for android_clang_dbg_recipe (see the linked bug), and this would allow us to recycle the shorter bot name. R=phajdan.jr@chromium.org BUG=434516 TEST=git cl try: doesn't trigger android_clang_dbg Committed: https://crrev.com/d138f04f43a4e1b7d22ba4b5b5c208a9a9de586c Cr-Commit-Position: refs/heads/master@{#305460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M PRESUBMIT.py View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Sergey Berezin
PTAL
6 years, 1 month ago (2014-11-21 20:23:55 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years ago (2014-11-24 15:25:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751613004/1
6 years ago (2014-11-24 18:26:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 19:08:03 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 19:08:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d138f04f43a4e1b7d22ba4b5b5c208a9a9de586c
Cr-Commit-Position: refs/heads/master@{#305460}

Powered by Google App Engine
This is Rietveld 408576698