Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: PRESUBMIT.py

Issue 751613004: Remove android_clang_dbg from PRESUBMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1580 matching lines...) Expand 10 before | Expand all | Expand 10 after
1591 # effectively update the perf expectation correctly. This requires a 1591 # effectively update the perf expectation correctly. This requires a
1592 # clobber=True build running 'sizes'. 'sizes' is not accurate with 1592 # clobber=True build running 'sizes'. 'sizes' is not accurate with
1593 # incremental build. Reference: 1593 # incremental build. Reference:
1594 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs. 1594 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs.
1595 # TODO(maruel): An option would be to run 'sizes' but not count a failure 1595 # TODO(maruel): An option would be to run 'sizes' but not count a failure
1596 # of this step as a try job failure. 1596 # of this step as a try job failure.
1597 'android_aosp': ['compile'], 1597 'android_aosp': ['compile'],
1598 'android_arm64_dbg_recipe': ['slave_steps'], 1598 'android_arm64_dbg_recipe': ['slave_steps'],
1599 'android_chromium_gn_compile_dbg': ['compile'], 1599 'android_chromium_gn_compile_dbg': ['compile'],
1600 'android_chromium_gn_compile_rel': ['compile'], 1600 'android_chromium_gn_compile_rel': ['compile'],
1601 'android_clang_dbg': ['slave_steps'],
1602 'android_clang_dbg_recipe': ['slave_steps'], 1601 'android_clang_dbg_recipe': ['slave_steps'],
1603 'android_dbg_tests_recipe': ['slave_steps'], 1602 'android_dbg_tests_recipe': ['slave_steps'],
1604 'cros_x86': ['defaulttests'], 1603 'cros_x86': ['defaulttests'],
1605 'ios_dbg_simulator': [ 1604 'ios_dbg_simulator': [
1606 'compile', 1605 'compile',
1607 'base_unittests', 1606 'base_unittests',
1608 'content_unittests', 1607 'content_unittests',
1609 'crypto_unittests', 1608 'crypto_unittests',
1610 'url_unittests', 1609 'url_unittests',
1611 'net_unittests', 1610 'net_unittests',
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
1692 ]) 1691 ])
1693 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 1692 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
1694 return GetDefaultTryConfigs([ 1693 return GetDefaultTryConfigs([
1695 'win_chromium_dbg', 1694 'win_chromium_dbg',
1696 'win_chromium_rel_ng', 1695 'win_chromium_rel_ng',
1697 'win8_chromium_rel', 1696 'win8_chromium_rel',
1698 ]) 1697 ])
1699 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files): 1698 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files):
1700 return GetDefaultTryConfigs([ 1699 return GetDefaultTryConfigs([
1701 'android_aosp', 1700 'android_aosp',
1702 'android_clang_dbg',
1703 'android_dbg_tests_recipe', 1701 'android_dbg_tests_recipe',
1704 ]) 1702 ])
1705 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files): 1703 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files):
1706 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) 1704 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
1707 1705
1708 builders = [ 1706 builders = [
1709 'android_arm64_dbg_recipe', 1707 'android_arm64_dbg_recipe',
1710 'android_chromium_gn_compile_rel', 1708 'android_chromium_gn_compile_rel',
1711 'android_chromium_gn_compile_dbg', 1709 'android_chromium_gn_compile_dbg',
1712 'android_clang_dbg',
1713 'android_clang_dbg_recipe', 1710 'android_clang_dbg_recipe',
1714 'android_dbg_tests_recipe', 1711 'android_dbg_tests_recipe',
1715 'ios_dbg_simulator', 1712 'ios_dbg_simulator',
1716 'ios_rel_device', 1713 'ios_rel_device',
1717 'ios_rel_device_ninja', 1714 'ios_rel_device_ninja',
1718 'linux_chromium_chromeos_rel', 1715 'linux_chromium_chromeos_rel',
1719 'linux_chromium_gn_dbg', 1716 'linux_chromium_gn_dbg',
1720 'linux_chromium_gn_rel', 1717 'linux_chromium_gn_rel',
1721 'linux_chromium_rel_ng', 1718 'linux_chromium_rel_ng',
1722 'linux_gpu', 1719 'linux_gpu',
(...skipping 23 matching lines...) Expand all
1746 builders.extend(['cros_x86']) 1743 builders.extend(['cros_x86'])
1747 1744
1748 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1745 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1749 # unless they're .gyp(i) files as changes to those files can break the gyp 1746 # unless they're .gyp(i) files as changes to those files can break the gyp
1750 # step on that bot. 1747 # step on that bot.
1751 if (not all(re.search('^chrome', f) for f in files) or 1748 if (not all(re.search('^chrome', f) for f in files) or
1752 any(re.search('\.gypi?$', f) for f in files)): 1749 any(re.search('\.gypi?$', f) for f in files)):
1753 builders.extend(['android_aosp']) 1750 builders.extend(['android_aosp'])
1754 1751
1755 return GetDefaultTryConfigs(builders) 1752 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698