Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 751593002: Removed add/removeScopedStyleResolver from StyleEngine (Closed)

Created:
6 years, 1 month ago by tasak
Modified:
6 years ago
Reviewers:
dglazkov, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, sof, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed add/removeScopedStyleResolver from StyleEngine Since ScopedStyleResolvers are owned by TreeScopes (i.e. replacing ScopedStyleTree with TreeScope tree), StyleEngine should know only about TreeScopes which have stylesheets. BUG=427249 TEST=fast/dom/StyleSheet/stylesheet-move-between-documents-crash.html,fast/dom/shadow/make-marquee-bold-by-exec-command-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186026

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed inspector/elements/edit-dom-actions.html #

Total comments: 9

Patch Set 3 : #

Messages

Total messages: 19 (4 generated)
tasak
Would you review this CL?
6 years, 1 month ago (2014-11-21 13:11:28 UTC) #2
dglazkov
lgtm
6 years, 1 month ago (2014-11-21 18:22:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751593002/1
6 years, 1 month ago (2014-11-21 18:23:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/32195)
6 years, 1 month ago (2014-11-21 19:34:16 UTC) #7
kochi
On 2014/11/21 19:34:16, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-21 23:15:55 UTC) #8
dglazkov
https://codereview.chromium.org/751593002/diff/1/Source/core/dom/StyleEngine.h File Source/core/dom/StyleEngine.h (right): https://codereview.chromium.org/751593002/diff/1/Source/core/dom/StyleEngine.h#newcode171 Source/core/dom/StyleEngine.h:171: bool onlyDocumentHasStyles() const { return m_activeTreeScopes.isEmpty(); } Much better ...
6 years, 1 month ago (2014-11-22 17:01:41 UTC) #9
tasak
Thank you for review. inspector/elements/edit-dom-actions.html is failing, because this patch causes StyleInvalidationSet's regression. I'm now ...
6 years ago (2014-11-25 12:29:47 UTC) #10
tasak
On 2014/11/25 12:29:47, tasak wrote: > I'm now trying to fix the problem. I uploaded ...
6 years ago (2014-11-26 05:17:13 UTC) #11
kochi
https://codereview.chromium.org/751593002/diff/20001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/751593002/diff/20001/Source/core/animation/css/CSSAnimations.cpp#newcode210 Source/core/animation/css/CSSAnimations.cpp:210: if (stack.isEmpty()) If the above onlyDocumentHasStyles() is not true, ...
6 years ago (2014-11-26 07:28:37 UTC) #12
tasak
https://codereview.chromium.org/751593002/diff/20001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/751593002/diff/20001/Source/core/animation/css/CSSAnimations.cpp#newcode210 Source/core/animation/css/CSSAnimations.cpp:210: if (stack.isEmpty()) On 2014/11/26 07:28:37, Takayoshi Kochi wrote: > ...
6 years ago (2014-11-26 08:46:33 UTC) #13
kochi
https://codereview.chromium.org/751593002/diff/20001/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/751593002/diff/20001/Source/core/animation/css/CSSAnimations.cpp#newcode210 Source/core/animation/css/CSSAnimations.cpp:210: if (stack.isEmpty()) On 2014/11/26 08:46:32, tasak wrote: > On ...
6 years ago (2014-11-26 09:12:07 UTC) #14
tasak
https://codereview.chromium.org/751593002/diff/20001/Source/core/css/resolver/StyleResolver.cpp File Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/751593002/diff/20001/Source/core/css/resolver/StyleResolver.cpp#newcode420 Source/core/css/resolver/StyleResolver.cpp:420: if (!resolvers.isEmpty()) { On 2014/11/26 09:12:07, Takayoshi Kochi wrote: ...
6 years ago (2014-11-26 09:40:57 UTC) #15
kochi
lgtm On 2014/11/26 09:40:57, tasak wrote: > https://codereview.chromium.org/751593002/diff/20001/Source/core/css/resolver/StyleResolver.cpp > File Source/core/css/resolver/StyleResolver.cpp (right): > > https://codereview.chromium.org/751593002/diff/20001/Source/core/css/resolver/StyleResolver.cpp#newcode420 ...
6 years ago (2014-11-26 10:00:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751593002/40001
6 years ago (2014-11-26 10:34:59 UTC) #18
commit-bot: I haz the power
6 years ago (2014-11-26 10:37:21 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186026

Powered by Google App Engine
This is Rietveld 408576698