Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 751583004: Fix llvm_symbolizer target on Win-Clang bots (Closed)

Created:
6 years, 1 month ago by hans
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix llvm_symbolizer target on Win-Clang bots This target was introduced in https://crrev.com/8207d3548f95ab41fec7734fcc4439c223102bc6, and was made a dependency of the chromium_builder_asan target in https://crrev.com/91f1267dbeddfdfdb5ac87de26932219e0c2dcf2. Because the Win-Clang builders build all targets, it would now fail because llvm-symbolizer is really called llvm-symbolizer.exe. BUG=82385 NOTRY=true Committed: https://crrev.com/e9a2eb83f19c1fdba942137f38cf3b5c4c560d18 Cr-Commit-Position: refs/heads/master@{#305264}

Patch Set 1 #

Total comments: 2

Patch Set 2 : I should have known. #

Patch Set 3 : Try to fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M build/sanitizers/sanitizers.gyp View 1 2 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
hans
Please take a look.
6 years, 1 month ago (2014-11-21 18:12:17 UTC) #2
Nico
https://codereview.chromium.org/751583004/diff/1/build/sanitizers/sanitizers.gyp File build/sanitizers/sanitizers.gyp (right): https://codereview.chromium.org/751583004/diff/1/build/sanitizers/sanitizers.gyp#newcode69 build/sanitizers/sanitizers.gyp:69: '../../third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer', gyp has a built-in variable for this. Say ...
6 years, 1 month ago (2014-11-21 18:14:08 UTC) #3
Nico
https://codereview.chromium.org/751583004/diff/1/build/sanitizers/sanitizers.gyp File build/sanitizers/sanitizers.gyp (right): https://codereview.chromium.org/751583004/diff/1/build/sanitizers/sanitizers.gyp#newcode69 build/sanitizers/sanitizers.gyp:69: '../../third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer', On 2014/11/21 18:14:08, Nico wrote: > gyp has ...
6 years, 1 month ago (2014-11-21 18:14:45 UTC) #4
hans
On 2014/11/21 18:14:45, Nico wrote: > https://codereview.chromium.org/751583004/diff/1/build/sanitizers/sanitizers.gyp > File build/sanitizers/sanitizers.gyp (right): > > https://codereview.chromium.org/751583004/diff/1/build/sanitizers/sanitizers.gyp#newcode69 > ...
6 years, 1 month ago (2014-11-21 18:24:27 UTC) #5
Nico
lgtm
6 years, 1 month ago (2014-11-21 18:32:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751583004/40001
6 years, 1 month ago (2014-11-21 18:38:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751583004/40001
6 years, 1 month ago (2014-11-21 19:26:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-21 19:27:57 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 19:29:14 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9a2eb83f19c1fdba942137f38cf3b5c4c560d18
Cr-Commit-Position: refs/heads/master@{#305264}

Powered by Google App Engine
This is Rietveld 408576698