Fix llvm_symbolizer target on Win-Clang bots

build/sanitizers/sanitizers.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'sanitizer_options',
       'type': 'static_library',
       'toolsets': ['host', 'target'],
@@ skipping 43 matching lines @@
             },
           }],
         ],
       },
     },
     {
       # Copy llvm-symbolizer to the product dir so that LKGR bots can package it.
       'target_name': 'llvm-symbolizer',
       'type': 'none',
       'variables': {
+
         # Path is relative to this GYP file.
-        'llvm_symbolizer_path':
-            '../../third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer',
+        'conditions': [
+          ['OS!="win"', {
+            'llvm_symbolizer_path':
+                '../../third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer',

[Nico, 2014/11/21 18:14:08]

gyp has a built-in variable for this. Say
'.......llvm-symbolizer<(EXECUTABLE_SUFFIX)'

[Nico, 2014/11/21 18:14:45]

(allows you to get rid of the conditional too)

+          }, {
+            'llvm_symbolizer_path':
+                '../../third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer.exe',
+          }],
+        ],
       },
       'conditions': [
         ['clang==1', {
           'copies': [
-            {
-              'destination': '<(PRODUCT_DIR)',
-              'files': [
-                '<(llvm_symbolizer_path)',
-              ],
-            },
+           {
+             'destination': '<(PRODUCT_DIR)',
+             'files': [
+               '<(llvm_symbolizer_path)',
+             ],
+           },
           ],
         }],
       ],
     },
   ],
 }