Issue 751323002: Simplify SVGPathByteStream-based path-query functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 751323002: Simplify SVGPathByteStream-based path-query functions (Closed)

Created:
6 years ago by fs

Modified:
6 years ago

Reviewers:
f(malita), kouhei (in TOK)

CC:
blink-reviews, krit, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify SVGPathByteStream-based path-query functions The functions getSVGPathSegAtLengthFromSVGPathByteStream, getTotalLengthOfSVGPathByteStream and getPointAtLengthOfSVGPathByteStream all returns a bool that their (single) caller does not look at. Convert to just return the computed value instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186025

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -26 lines)			Patch
M	Source/core/svg/SVGPathElement.cpp	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	Source/core/svg/SVGPathUtilities.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGPathUtilities.cpp	View	1 chunk	+12 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751323002/1

6 years ago (2014-11-26 09:42:33 UTC) #6

commit-bot: I haz the power

6 years ago (2014-11-26 10:28:17 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186025

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages