Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 7511030: Merge 95551 - [ChromeOS] Assorted WebUI login fixes. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
Reviewers:
zel
CC:
chromium-reviews, arv (Not doing code reviews), rharrison, davemoore+watch_chromium.org, nkostylev+cc_chromium.org
Visibility:
Public.

Description

Merge 95551 - [ChromeOS] Assorted WebUI login fixes. - Respect account settings by using the users list and other flags passed into WebUILoginDisplay::Init; - Limit max 5 users to avoid scrolling in account picker; - Increase account picker width to 1100px to avoid crop on user pods; - Properly remove a user, i.e. go through UserManager::RemoveUser instead of delete it directly using RemoveUserFromList; - Improve the tab order; - Switch to Gaia sign in if user failed login three times in a row; - Turn off init animation; BUG=chromium-os:18532, chromium-os:18668, chromium-os:18312, chromium-os:18307 TEST=Verify fix for chromium-os:18532,chromium-os:18668,chrmoum-os:18312 and chromium-os:18307. Review URL: http://codereview.chromium.org/7461142 TBR=zelidrag@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95553

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
xiyuan
9 years, 4 months ago (2011-08-05 01:52:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698