Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 750983003: DevTools: remove Console.setTracingBasedTimeline call from startup. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/ConsoleBase.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorConsoleAgent.h
diff --git a/Source/core/inspector/InspectorConsoleAgent.h b/Source/core/inspector/InspectorConsoleAgent.h
index e0eb4b75bfb635ef034bda7f5eb4a6febfd1d82d..176a4afb58d04e3d73564db0fb88f8b5ad0d056d 100644
--- a/Source/core/inspector/InspectorConsoleAgent.h
+++ b/Source/core/inspector/InspectorConsoleAgent.h
@@ -46,7 +46,6 @@ class DocumentLoader;
class LocalFrame;
class InspectorFrontend;
class InjectedScriptManager;
-class InspectorTimelineAgent;
class ScriptProfile;
class ThreadableLoaderClient;
class XMLHttpRequest;
@@ -56,7 +55,7 @@ typedef String ErrorString;
class InspectorConsoleAgent : public InspectorBaseAgent<InspectorConsoleAgent>, public InspectorBackendDispatcher::ConsoleCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorConsoleAgent);
public:
- InspectorConsoleAgent(InspectorTimelineAgent*, InjectedScriptManager*);
+ explicit InspectorConsoleAgent(InjectedScriptManager*);
virtual ~InspectorConsoleAgent();
virtual void trace(Visitor*) override;
@@ -72,10 +71,6 @@ public:
void addMessageToConsole(ConsoleMessage*);
void consoleMessagesCleared();
- void setTracingBasedTimeline(ErrorString*, bool enabled);
- void consoleTimeline(ExecutionContext*, const String& title, ScriptState*);
- void consoleTimelineEnd(ExecutionContext*, const String& title, ScriptState*);
-
void didCommitLoad(LocalFrame*, DocumentLoader*);
void didFinishXHRLoading(XMLHttpRequest*, ThreadableLoaderClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& method, const String& url);
@@ -96,7 +91,6 @@ protected:
virtual void enableStackCapturingIfNeeded() = 0;
virtual void disableStackCapturingIfNeeded() = 0;
- RawPtrWillBeMember<InspectorTimelineAgent> m_timelineAgent;
RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
InspectorFrontend::Console* m_frontend;
bool m_enabled;
« no previous file with comments | « Source/core/frame/ConsoleBase.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698