Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 750983003: DevTools: remove Console.setTracingBasedTimeline call from startup. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/ConsoleBase.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 #include "wtf/text/StringHash.h" 39 #include "wtf/text/StringHash.h"
40 40
41 namespace blink { 41 namespace blink {
42 42
43 class ConsoleMessage; 43 class ConsoleMessage;
44 class ConsoleMessageStorage; 44 class ConsoleMessageStorage;
45 class DocumentLoader; 45 class DocumentLoader;
46 class LocalFrame; 46 class LocalFrame;
47 class InspectorFrontend; 47 class InspectorFrontend;
48 class InjectedScriptManager; 48 class InjectedScriptManager;
49 class InspectorTimelineAgent;
50 class ScriptProfile; 49 class ScriptProfile;
51 class ThreadableLoaderClient; 50 class ThreadableLoaderClient;
52 class XMLHttpRequest; 51 class XMLHttpRequest;
53 52
54 typedef String ErrorString; 53 typedef String ErrorString;
55 54
56 class InspectorConsoleAgent : public InspectorBaseAgent<InspectorConsoleAgent>, public InspectorBackendDispatcher::ConsoleCommandHandler { 55 class InspectorConsoleAgent : public InspectorBaseAgent<InspectorConsoleAgent>, public InspectorBackendDispatcher::ConsoleCommandHandler {
57 WTF_MAKE_NONCOPYABLE(InspectorConsoleAgent); 56 WTF_MAKE_NONCOPYABLE(InspectorConsoleAgent);
58 public: 57 public:
59 InspectorConsoleAgent(InspectorTimelineAgent*, InjectedScriptManager*); 58 explicit InspectorConsoleAgent(InjectedScriptManager*);
60 virtual ~InspectorConsoleAgent(); 59 virtual ~InspectorConsoleAgent();
61 virtual void trace(Visitor*) override; 60 virtual void trace(Visitor*) override;
62 61
63 virtual void enable(ErrorString*) override final; 62 virtual void enable(ErrorString*) override final;
64 virtual void disable(ErrorString*) override final; 63 virtual void disable(ErrorString*) override final;
65 virtual void clearMessages(ErrorString*) override; 64 virtual void clearMessages(ErrorString*) override;
66 bool enabled() { return m_enabled; } 65 bool enabled() { return m_enabled; }
67 66
68 virtual void setFrontend(InspectorFrontend*) override final; 67 virtual void setFrontend(InspectorFrontend*) override final;
69 virtual void clearFrontend() override final; 68 virtual void clearFrontend() override final;
70 virtual void restore() override final; 69 virtual void restore() override final;
71 70
72 void addMessageToConsole(ConsoleMessage*); 71 void addMessageToConsole(ConsoleMessage*);
73 void consoleMessagesCleared(); 72 void consoleMessagesCleared();
74 73
75 void setTracingBasedTimeline(ErrorString*, bool enabled);
76 void consoleTimeline(ExecutionContext*, const String& title, ScriptState*);
77 void consoleTimelineEnd(ExecutionContext*, const String& title, ScriptState* );
78
79 void didCommitLoad(LocalFrame*, DocumentLoader*); 74 void didCommitLoad(LocalFrame*, DocumentLoader*);
80 75
81 void didFinishXHRLoading(XMLHttpRequest*, ThreadableLoaderClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& method, const String& url); 76 void didFinishXHRLoading(XMLHttpRequest*, ThreadableLoaderClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& method, const String& url);
82 void addProfileFinishedMessageToConsole(PassRefPtrWillBeRawPtr<ScriptProfile >, unsigned lineNumber, const String& sourceURL); 77 void addProfileFinishedMessageToConsole(PassRefPtrWillBeRawPtr<ScriptProfile >, unsigned lineNumber, const String& sourceURL);
83 void addStartProfilingMessageToConsole(const String& title, unsigned lineNum ber, const String& sourceURL); 78 void addStartProfilingMessageToConsole(const String& title, unsigned lineNum ber, const String& sourceURL);
84 virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) override; 79 virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) override;
85 virtual void addInspectedNode(ErrorString*, int nodeId) = 0; 80 virtual void addInspectedNode(ErrorString*, int nodeId) = 0;
86 virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) override; 81 virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) override;
87 82
88 virtual bool isWorkerAgent() = 0; 83 virtual bool isWorkerAgent() = 0;
89 84
90 virtual void setLastEvaluationResult(ErrorString*, const String& objectId) o verride; 85 virtual void setLastEvaluationResult(ErrorString*, const String& objectId) o verride;
91 86
92 protected: 87 protected:
93 void sendConsoleMessageToFrontend(ConsoleMessage*, bool generatePreview); 88 void sendConsoleMessageToFrontend(ConsoleMessage*, bool generatePreview);
94 virtual ConsoleMessageStorage* messageStorage() = 0; 89 virtual ConsoleMessageStorage* messageStorage() = 0;
95 90
96 virtual void enableStackCapturingIfNeeded() = 0; 91 virtual void enableStackCapturingIfNeeded() = 0;
97 virtual void disableStackCapturingIfNeeded() = 0; 92 virtual void disableStackCapturingIfNeeded() = 0;
98 93
99 RawPtrWillBeMember<InspectorTimelineAgent> m_timelineAgent;
100 RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager; 94 RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
101 InspectorFrontend::Console* m_frontend; 95 InspectorFrontend::Console* m_frontend;
102 bool m_enabled; 96 bool m_enabled;
103 }; 97 };
104 98
105 } // namespace blink 99 } // namespace blink
106 100
107 101
108 #endif // !defined(InspectorConsoleAgent_h) 102 #endif // !defined(InspectorConsoleAgent_h)
OLDNEW
« no previous file with comments | « Source/core/frame/ConsoleBase.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698